Re: [libvirt] [PATCH] qemu: Remove redundant code in qemuParseCommandLineDisk

2017-10-10 Thread Ján Tomko 

On Sun, Oct 08, 2017 at 02:54:53PM +0530, Kothapally Madhu Pavan wrote:

Signed-off-by: Kothapally Madhu Pavan 
---
src/qemu/qemu_parse_command.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)



ACK and pushed.

Jan


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] qemu: Remove redundant code in qemuParseCommandLineDisk

2017-10-08 Thread Kothapally Madhu Pavan 
Signed-off-by: Kothapally Madhu Pavan 
---
 src/qemu/qemu_parse_command.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c
index 37e1149..7c409b0 100644
--- a/src/qemu/qemu_parse_command.c
+++ b/src/qemu/qemu_parse_command.c
@@ -945,9 +945,7 @@ qemuParseCommandLineDisk(virDomainXMLOptionPtr xmlopt,
 if (virDomainDiskDefAssignAddress(xmlopt, def, dom) < 0) {
 virReportError(VIR_ERR_INTERNAL_ERROR,
_("invalid device name '%s'"), def->dst);
-virDomainDiskDefFree(def);
-def = NULL;
-goto cleanup;
+goto error;
 }
 
  cleanup:
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list