Re: [libvirt] [PATCH] qemu: Reset hostModelInfo in virQEMUCapsReset

2017-01-19 Thread Pavel Hrdina 
On Wed, Jan 18, 2017 at 04:50:42PM +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark 
> ---
>  src/qemu/qemu_capabilities.c | 3 +++
>  1 file changed, 3 insertions(+)

ACK

Pavel


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Reset hostModelInfo in virQEMUCapsReset

2017-01-18 Thread Jason J. Herne 

On 01/18/2017 10:50 AM, Jiri Denemark wrote:

Signed-off-by: Jiri Denemark 
---
 src/qemu/qemu_capabilities.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 89e9dd471..1e1b53b22 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -3752,6 +3752,9 @@ virQEMUCapsReset(virQEMUCapsPtr qemuCaps)
 VIR_FREE(qemuCaps->gicCapabilities);
 qemuCaps->ngicCapabilities = 0;

+qemuMonitorCPUModelInfoFree(qemuCaps->hostCPUModelInfo);
+qemuCaps->hostCPUModelInfo = NULL;
+
 virCPUDefFree(qemuCaps->hostCPUModel);
 qemuCaps->hostCPUModel = NULL;
 }



Fwiw,

Looks good to me.

Reviewed-by: Jason J. Herne 

--
-- Jason J. Herne (jjhe...@linux.vnet.ibm.com)

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] qemu: Reset hostModelInfo in virQEMUCapsReset

2017-01-18 Thread Jiri Denemark 
Signed-off-by: Jiri Denemark 
---
 src/qemu/qemu_capabilities.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 89e9dd471..1e1b53b22 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -3752,6 +3752,9 @@ virQEMUCapsReset(virQEMUCapsPtr qemuCaps)
 VIR_FREE(qemuCaps->gicCapabilities);
 qemuCaps->ngicCapabilities = 0;
 
+qemuMonitorCPUModelInfoFree(qemuCaps->hostCPUModelInfo);
+qemuCaps->hostCPUModelInfo = NULL;
+
 virCPUDefFree(qemuCaps->hostCPUModel);
 qemuCaps->hostCPUModel = NULL;
 }
-- 
2.11.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list