Re: [libvirt] [PATCH] qemu: Set default SCSI controller model for S390 arch
On 20.03.2015 16:01, Boris Fiuczynski wrote: > When no model is specified in the domain definition for > a scsi controller and the architectur is s390 than virtio-scsi > is set as default model. > > Signed-off-by: Boris Fiuczynski > Reviewed-by: Daniel Hansel > Reviewed-by: Stefan Zimmermann > --- > src/qemu/qemu_domain.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index 41d1263..949bf8b 100644 > --- a/src/qemu/qemu_domain.c > +++ b/src/qemu/qemu_domain.c > @@ -1148,6 +1148,13 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev, > ARCH_IS_S390(def->os.arch)) > dev->data.controller->model = VIR_DOMAIN_CONTROLLER_MODEL_USB_NONE; > > +/* set the default SCSI controller model for S390 arches */ > +if (dev->type == VIR_DOMAIN_DEVICE_CONTROLLER && > +dev->data.controller->type == VIR_DOMAIN_CONTROLLER_TYPE_SCSI && > +dev->data.controller->model == -1 && > +ARCH_IS_S390(def->os.arch)) > +dev->data.controller->model = > VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI; > + > /* auto generate unix socket path */ > if (dev->type == VIR_DOMAIN_DEVICE_CHR && > dev->data.chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL && > ACKed and pushed. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: Set default SCSI controller model for S390 arch
On Fri, Mar 20, 2015 at 04:01:10PM +0100, Boris Fiuczynski wrote: > When no model is specified in the domain definition for > a scsi controller and the architectur is s390 than virtio-scsi > is set as default model. > > Signed-off-by: Boris Fiuczynski > Reviewed-by: Daniel Hansel > Reviewed-by: Stefan Zimmermann > --- > src/qemu/qemu_domain.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index 41d1263..949bf8b 100644 > --- a/src/qemu/qemu_domain.c > +++ b/src/qemu/qemu_domain.c > @@ -1148,6 +1148,13 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev, > ARCH_IS_S390(def->os.arch)) > dev->data.controller->model = VIR_DOMAIN_CONTROLLER_MODEL_USB_NONE; > > +/* set the default SCSI controller model for S390 arches */ > +if (dev->type == VIR_DOMAIN_DEVICE_CONTROLLER && > +dev->data.controller->type == VIR_DOMAIN_CONTROLLER_TYPE_SCSI && > +dev->data.controller->model == -1 && > +ARCH_IS_S390(def->os.arch)) > +dev->data.controller->model = > VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI; > + I think it's good to make this the default on s390. So, FWIW Reviewed-by: Jens Freimann -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH] qemu: Set default SCSI controller model for S390 arch
When no model is specified in the domain definition for a scsi controller and the architectur is s390 than virtio-scsi is set as default model. Signed-off-by: Boris Fiuczynski Reviewed-by: Daniel Hansel Reviewed-by: Stefan Zimmermann --- src/qemu/qemu_domain.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 41d1263..949bf8b 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1148,6 +1148,13 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev, ARCH_IS_S390(def->os.arch)) dev->data.controller->model = VIR_DOMAIN_CONTROLLER_MODEL_USB_NONE; +/* set the default SCSI controller model for S390 arches */ +if (dev->type == VIR_DOMAIN_DEVICE_CONTROLLER && +dev->data.controller->type == VIR_DOMAIN_CONTROLLER_TYPE_SCSI && +dev->data.controller->model == -1 && +ARCH_IS_S390(def->os.arch)) +dev->data.controller->model = VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI; + /* auto generate unix socket path */ if (dev->type == VIR_DOMAIN_DEVICE_CHR && dev->data.chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL && -- 2.3.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
