Re: [libvirt] [PATCH] scripts: fix list indexing when printing mis-ordered symbols

2019-12-04 Thread Michal Privoznik 

On 12/3/19 6:15 PM, Daniel P. Berrangé wrote:

The python array slice syntax expects the first and last indexes,
not the first length and element count.

Signed-off-by: Daniel P. Berrangé 
---
  scripts/check-symsorting.py | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Michal Privoznik 

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] scripts: fix list indexing when printing mis-ordered symbols

2019-12-03 Thread Daniel P . Berrangé 
The python array slice syntax expects the first and last indexes,
not the first length and element count.

Signed-off-by: Daniel P. Berrangé 
---
 scripts/check-symsorting.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/check-symsorting.py b/scripts/check-symsorting.py
index 8e698c0657..006c42f1b3 100755
--- a/scripts/check-symsorting.py
+++ b/scripts/check-symsorting.py
@@ -59,8 +59,8 @@ def check_sorting(group, symfile, line, groupfile, lastgroup):
 issorted = False
 
 if not issorted:
-actual = group[first:(last - first + 1)]
-expect = sortedgroup[first:(last - first + 1)]
+actual = group[first:last]
+expect = sortedgroup[first:last]
 print("Symbol block at %s:%s: symbols not sorted" %
   (symfile, line), file=sys.stderr)
 for g in actual:
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list