Re: [libvirt] [PATCH] typo: fix typo error in virLXCControllerSetupResourceLimits

2015-04-27 Thread Ján Tomko
On Sat, Apr 25, 2015 at 02:10:00PM +0800, zhang bo wrote:
 iff - if

Michal insists that iff is a real word meaning 'if and only if':
http://en.wiktionary.org/wiki/iff
So we shouldn't correct it as a typo.

 rather then - rather than
 
 Signed-off-by: YueWenyuan yueweny...@huawei.com
 ---
  src/lxc/lxc_controller.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
 index e144c2d..7ad9d50 100644
 --- a/src/lxc/lxc_controller.c
 +++ b/src/lxc/lxc_controller.c
 @@ -745,9 +745,9 @@ static int 
 virLXCControllerSetupResourceLimits(virLXCControllerPtr ctrl)
  
  if (mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT 
  virCgroupControllerAvailable(VIR_CGROUP_CONTROLLER_CPUSET)) {
 -/* Use virNuma* API iff necessary. Once set and child is exec()-ed,
 +/* Use virNuma* API if necessary. Once set and child is exec()-ed,
   * there's no way for us to change it. Rely on cgroups (if available
 - * and enabled in the config) rather then virNuma*. */
 + * and enabled in the config) rather than virNuma*. */

This was copied from a similar code in qemuProcessHook that has the same
typo.

  VIR_DEBUG(Relying on CGroups for memory binding);
  } else {
  

ACK, I have removed the iff-if change and fixed 'then' in qemu_process
as well before pushing the patch.

Jan


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] typo: fix typo error in virLXCControllerSetupResourceLimits

2015-04-25 Thread zhang bo
iff - if
rather then - rather than

Signed-off-by: YueWenyuan yueweny...@huawei.com
---
 src/lxc/lxc_controller.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
index e144c2d..7ad9d50 100644
--- a/src/lxc/lxc_controller.c
+++ b/src/lxc/lxc_controller.c
@@ -745,9 +745,9 @@ static int 
virLXCControllerSetupResourceLimits(virLXCControllerPtr ctrl)
 
 if (mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT 
 virCgroupControllerAvailable(VIR_CGROUP_CONTROLLER_CPUSET)) {
-/* Use virNuma* API iff necessary. Once set and child is exec()-ed,
+/* Use virNuma* API if necessary. Once set and child is exec()-ed,
  * there's no way for us to change it. Rely on cgroups (if available
- * and enabled in the config) rather then virNuma*. */
+ * and enabled in the config) rather than virNuma*. */
 VIR_DEBUG(Relying on CGroups for memory binding);
 } else {
 
-- 
1.7.12.4


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list