Re: [libvirt] [PATCH] util: Fix a typo in comments of virresctrl.c

[Andrea Bolognani]

On Wed, 2018-10-17 at 16:27 +0800, Wang Huaqiang wrote:
> Signed-off-by: Wang Huaqiang 
> ---
>  src/util/virresctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Andrea Bolognani 

and pushed.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] util: Fix a typo in comments of virresctrl.c

[Wang Huaqiang]

Signed-off-by: Wang Huaqiang 
---
 src/util/virresctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index df5b512..5d811a2 100644
--- a/src/util/virresctrl.c
+++ b/src/util/virresctrl.c
@@ -259,7 +259,7 @@ virResctrlInfoMonFree(virResctrlInfoMonPtr mon)
  * all of them.  While doing that we store the bitmask in a sparse array of
  * virBitmaps named `masks` indexed the same way as `sizes`.  The upper bounds
  * of the sparse arrays are stored in nmasks or nsizes, respectively.
- + *
+ *
  * =Memory Bandwidth allocation technology (MBA)=
  *
  * The memory bandwidth allocation support in virResctrlAlloc works in the
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: fix a typo

[Andrea Bolognani]

On Mon, 2016-06-20 at 19:52 +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao 
> 
> s/succcess/success
> 
> Signed-off-by: Chen Hanxiao 
> ---
>  src/util/virfile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/util/virfile.c b/src/util/virfile.c
> index 9d460b9..f47bf39 100644
> --- a/src/util/virfile.c
> +++ b/src/util/virfile.c
> @@ -406,7 +406,7 @@ int virFileLock(int fd, bool shared, off_t start, off_t 
> len, bool waitForLock)
>   * NB the lock will also be released if any open file descriptor
>   * pointing to the same file as @fd is closed
>   *
> - * Returns 0 on succcess, or -errno on error
> + * Returns 0 on success, or -errno on error
>   */
>  int virFileUnlock(int fd, off_t start, off_t len)
>  {

ACK and pushed, thanks! :)

-- 
Andrea Bolognani
Software Engineer - Virtualization Team

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] util: fix a typo

[Chen Hanxiao]

From: Chen Hanxiao 

s/succcess/success

Signed-off-by: Chen Hanxiao 
---
 src/util/virfile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virfile.c b/src/util/virfile.c
index 9d460b9..f47bf39 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -406,7 +406,7 @@ int virFileLock(int fd, bool shared, off_t start, off_t 
len, bool waitForLock)
  * NB the lock will also be released if any open file descriptor
  * pointing to the same file as @fd is closed
  *
- * Returns 0 on succcess, or -errno on error
+ * Returns 0 on success, or -errno on error
  */
 int virFileUnlock(int fd, off_t start, off_t len)
 {
-- 
1.8.3.1


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] util: fix a typo in virprocess.c

[Hongwei Bi]

s/forcably/forcibly

Signed-off-by: Hongwei Bi hwbi2...@gmail.com
---
 src/util/virprocess.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virprocess.c b/src/util/virprocess.c
index 405ad06..9179d73 100644
--- a/src/util/virprocess.c
+++ b/src/util/virprocess.c
@@ -283,7 +283,7 @@ int virProcessKill(pid_t pid, int sig)
  * Try to kill the process and verify it has exited
  *
  * Returns 0 if it was killed gracefully, 1 if it
- * was killed forcably, -1 if it is still alive,
+ * was killed forcibly, -1 if it is still alive,
  * or another error occurred.
  */
 int
-- 
1.7.9.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] util: fix a typo on return value

[Guannan Ren]

virNetDevTapCreateInBridgePort
returns 0 in case of success or -1 on failure
---
 src/util/virnetdevtap.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c
index 6ccc380..83f2ecd 100644
--- a/src/util/virnetdevtap.c
+++ b/src/util/virnetdevtap.c
@@ -341,5 +341,5 @@ int virNetDevTapCreateInBridgePort(const char *brname,
 if (tapfd)
 VIR_FORCE_CLOSE(*tapfd);
 
-return errno;
+return -1;
 }
-- 
1.7.7.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: fix a typo on return value

[Osier Yang]

On 2012年07月25日 17:02, Guannan Ren wrote:

virNetDevTapCreateInBridgePort
returns 0 in case of success or -1 on failure
---
  src/util/virnetdevtap.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c
index 6ccc380..83f2ecd 100644
--- a/src/util/virnetdevtap.c
+++ b/src/util/virnetdevtap.c
@@ -341,5 +341,5 @@ int virNetDevTapCreateInBridgePort(const char *brname,
  if (tapfd)
  VIR_FORCE_CLOSE(*tapfd);

-return errno;
+return -1;
  }


You might want to fix the comment for virNetDevTapCreate
together.

...
Returns 0 in case of success or an errno code in case of failure.
/...

Regards,
Osier

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: fix a typo on return value

[Guannan Ren]

On 07/25/2012 05:17 PM, Osier Yang wrote:

On 2012年07月25日 17:02, Guannan Ren wrote:

virNetDevTapCreateInBridgePort
returns 0 in case of success or -1 on failure
---
  src/util/virnetdevtap.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c
index 6ccc380..83f2ecd 100644
--- a/src/util/virnetdevtap.c
+++ b/src/util/virnetdevtap.c
@@ -341,5 +341,5 @@ int virNetDevTapCreateInBridgePort(const char 
*brname,

  if (tapfd)
  VIR_FORCE_CLOSE(*tapfd);

-return errno;
+return -1;
  }


You might want to fix the comment for virNetDevTapCreate
together.

...
Returns 0 in case of success or an errno code in case of failure.
/...

Regards,
Osier


   it should return -1 instead of errno on error, the comment is right.


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: fix a typo on return value

[Osier Yang]

On 2012年07月25日 17:22, Guannan Ren wrote:

On 07/25/2012 05:17 PM, Osier Yang wrote:

On 2012年07月25日 17:02, Guannan Ren wrote:

virNetDevTapCreateInBridgePort
returns 0 in case of success or -1 on failure
---
src/util/virnetdevtap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c
index 6ccc380..83f2ecd 100644
--- a/src/util/virnetdevtap.c
+++ b/src/util/virnetdevtap.c
@@ -341,5 +341,5 @@ int virNetDevTapCreateInBridgePort(const char
*brname,
if (tapfd)
VIR_FORCE_CLOSE(*tapfd);

- return errno;
+ return -1;
}


You might want to fix the comment for virNetDevTapCreate
together.

...
Returns 0 in case of success or an errno code in case of failure.
/...

Regards,
Osier


it should return -1 instead of errno on error, the comment is right.



No, I'm talking about another function virNetDevTapCreate in
the util/virnetdevtap.c


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: fix a typo

[Alex Jia]

On 02/29/2012 04:21 PM, Daniel P. Berrange wrote:

On Wed, Feb 29, 2012 at 02:54:38PM +0800, Alex Jia wrote:

* src/util/event_poll.c: (virEventPollRunOnce): s/imeout/timeout/.

Signed-off-by: Alex Jiaa...@redhat.com
---
  src/util/event_poll.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/event_poll.c b/src/util/event_poll.c
index 30dec74..038e75f 100644
--- a/src/util/event_poll.c
+++ b/src/util/event_poll.c
@@ -615,7 +615,7 @@ int virEventPollRunOnce(void) {

   retry:
  PROBE(EVENT_POLL_RUN,
-  nhandles=%d imeout=%d,
+  nhandles=%d timeout=%d,
nfds, timeout);
  ret = poll(fds, nfds, timeout);
  if (ret  0) {


ACK


Daniel

Thanks and push now.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] util: fix a typo

[Alex Jia]

* src/util/event_poll.c: (virEventPollRunOnce): s/imeout/timeout/.

Signed-off-by: Alex Jia a...@redhat.com
---
 src/util/event_poll.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/event_poll.c b/src/util/event_poll.c
index 30dec74..038e75f 100644
--- a/src/util/event_poll.c
+++ b/src/util/event_poll.c
@@ -615,7 +615,7 @@ int virEventPollRunOnce(void) {
 
  retry:
 PROBE(EVENT_POLL_RUN,
-  nhandles=%d imeout=%d,
+  nhandles=%d timeout=%d,
   nfds, timeout);
 ret = poll(fds, nfds, timeout);
 if (ret  0) {
-- 
1.7.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] util: fix a typo error on virStrncpy

[ajia]

* src/util/util.c: fix a typo error on virStrncpy.
---
 src/util/util.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/util.c b/src/util/util.c
index 0ca81df..1080823 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -1754,7 +1754,7 @@ virStrncpy(char *dest, const char *src, size_t n, size_t 
destbytes)
 return NULL;
 
 ret = strncpy(dest, src, n);
-/* strncpy NULL terminates iff the last character is \0.  Therefore
+/* strncpy NULL terminates if the last character is \0.  Therefore
  * force the last byte to be \0
  */
 dest[n] = '\0';
-- 
1.7.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: fix a typo error on virStrncpy

[Matthias Bolte]

2011/7/15  a...@redhat.com:
 * src/util/util.c: fix a typo error on virStrncpy.
 ---
  src/util/util.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

 diff --git a/src/util/util.c b/src/util/util.c
 index 0ca81df..1080823 100644
 --- a/src/util/util.c
 +++ b/src/util/util.c
 @@ -1754,7 +1754,7 @@ virStrncpy(char *dest, const char *src, size_t n, 
 size_t destbytes)
         return NULL;

     ret = strncpy(dest, src, n);
 -    /* strncpy NULL terminates iff the last character is \0.  Therefore
 +    /* strncpy NULL terminates if the last character is \0.  Therefore

This is not necessarily a typo. iff is short for 'if and only if'.

-- 
Matthias Bolte
http://photron.blogspot.com

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: fix a typo error on virStrncpy

[Alex Jia]

On 07/15/2011 05:11 PM, Matthias Bolte wrote:

2011/7/15a...@redhat.com:

* src/util/util.c: fix a typo error on virStrncpy.
---
  src/util/util.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/util/util.c b/src/util/util.c
index 0ca81df..1080823 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -1754,7 +1754,7 @@ virStrncpy(char *dest, const char *src, size_t n, size_t 
destbytes)
 return NULL;

 ret = strncpy(dest, src, n);
-/* strncpy NULL terminates iff the last character is \0.  Therefore
+/* strncpy NULL terminates if the last character is \0.  Therefore

This is not necessarily a typo. iff is short for 'if and only if'.


Matthias, thanks,I know what the 'iff' is now :-)

Regards,
Alex

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list