Re: [libvirt] [PATCH] virDomainSnapshotDefParse: Prefer VIR_STEAL_PTR

[Erik Skultety]

On Thu, Jun 21, 2018 at 02:45:43PM +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik 
> ---
Trivial..

Reviewed-by: Erik Skultety 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] virDomainSnapshotDefParse: Prefer VIR_STEAL_PTR

[Michal Privoznik]

Signed-off-by: Michal Privoznik 
---
 src/conf/snapshot_conf.c | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index 787c3d0feb..9c537ac7d1 100644
--- a/src/conf/snapshot_conf.c
+++ b/src/conf/snapshot_conf.c
@@ -331,8 +331,7 @@ virDomainSnapshotDefParse(xmlXPathContextPtr ctxt,
  "disk-only snapshot"));
 goto cleanup;
 }
-def->file = memoryFile;
-memoryFile = NULL;
+VIR_STEAL_PTR(def->file, memoryFile);
 
 /* verify that memory path is absolute */
 if (def->file && def->file[0] != '/') {
@@ -372,7 +371,7 @@ virDomainSnapshotDefParse(xmlXPathContextPtr ctxt,
 if (!offline && virSaveCookieParse(ctxt, >cookie, saveCookie) < 0)
 goto cleanup;
 
-ret = def;
+VIR_STEAL_PTR(ret, def);
 
  cleanup:
 VIR_FREE(creation);
@@ -380,8 +379,7 @@ virDomainSnapshotDefParse(xmlXPathContextPtr ctxt,
 VIR_FREE(nodes);
 VIR_FREE(memorySnapshot);
 VIR_FREE(memoryFile);
-if (ret == NULL)
-virDomainSnapshotDefFree(def);
+virDomainSnapshotDefFree(def);
 
 return ret;
 }
-- 
2.16.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list