Re: [libvirt] [PATCH] virsh: fix cpu-stats command output format issue

2016-01-26 Thread lhuang 



On 01/26/2016 04:24 PM, Peter Krempa wrote:

On Tue, Jan 26, 2016 at 10:25:05 +0800, Luyao Huang wrote:

After commit 57177f1, the cpu-stats command format change to:

CPU0:
 cpu_time 14401.507878990 seconds
 vcpu_time14378732785511

vcpu_time is not user friendly. After this patch, it will
change back:
CPU0:
 cpu_time 14401.507878990 seconds
 vcpu_time14378.732785511 seconds

https://bugzilla.redhat.com/show_bug.cgi?id=1301807

Signed-off-by: Luyao Huang 
---
  tools/virsh-domain.c | 1 +
  1 file changed, 1 insertion(+)

ACK, I'll push it shortly.


Thanks a lot for your quick review,

Luyao


Peter


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: fix cpu-stats command output format issue

2016-01-26 Thread Peter Krempa 
On Tue, Jan 26, 2016 at 10:25:05 +0800, Luyao Huang wrote:
> After commit 57177f1, the cpu-stats command format change to:
> 
> CPU0:
> cpu_time 14401.507878990 seconds
> vcpu_time14378732785511
> 
> vcpu_time is not user friendly. After this patch, it will
> change back:
> CPU0:
> cpu_time 14401.507878990 seconds
> vcpu_time14378.732785511 seconds
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1301807
> 
> Signed-off-by: Luyao Huang 
> ---
>  tools/virsh-domain.c | 1 +
>  1 file changed, 1 insertion(+)

ACK, I'll push it shortly.

Peter


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] virsh: fix cpu-stats command output format issue

2016-01-25 Thread Luyao Huang 
After commit 57177f1, the cpu-stats command format change to:

CPU0:
cpu_time 14401.507878990 seconds
vcpu_time14378732785511

vcpu_time is not user friendly. After this patch, it will
change back:
CPU0:
cpu_time 14401.507878990 seconds
vcpu_time14378.732785511 seconds

https://bugzilla.redhat.com/show_bug.cgi?id=1301807

Signed-off-by: Luyao Huang 
---
 tools/virsh-domain.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 1089a4d..c2146d2 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -7243,6 +7243,7 @@ vshCPUStatsPrintField(vshControl *ctl,
 {
 vshPrint(ctl, "\t%-12s ", param->field);
 if ((STREQ(param->field, VIR_DOMAIN_CPU_STATS_CPUTIME) ||
+ STREQ(param->field, VIR_DOMAIN_CPU_STATS_VCPUTIME) ||
  STREQ(param->field, VIR_DOMAIN_CPU_STATS_USERTIME) ||
  STREQ(param->field, VIR_DOMAIN_CPU_STATS_SYSTEMTIME)) &&
 param->type == VIR_TYPED_PARAM_ULLONG) {
-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list