Re: [libvirt] [PATCH] xenconfig: fix xml conversion convert with no graphics

[Jim Fehlig]

Joao Martins wrote:
> If no graphics element is in XML xenFormatXLSpice will access
> graphics without checking it has one in the first place, leading to a
> segmentation fault.
> 
> Signed-off-by: Joao Martins 

ACK. I changed the commit description to "xenconfig: fix xml to xl.cfg
conversion with no graphics" and pushed the patch. Thanks!

Regards,
Jim

> ---
>  src/xenconfig/xen_xl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c
> index 2c9174e..74f68b3 100644
> --- a/src/xenconfig/xen_xl.c
> +++ b/src/xenconfig/xen_xl.c
> @@ -1168,7 +1168,7 @@ xenFormatXLSpice(virConfPtr conf, virDomainDefPtr def)
>  virDomainGraphicsListenDefPtr glisten;
>  virDomainGraphicsDefPtr graphics;
>  
> -if (def->os.type == VIR_DOMAIN_OSTYPE_HVM) {
> +if (def->os.type == VIR_DOMAIN_OSTYPE_HVM && def->graphics) {
>  graphics = def->graphics[0];
>  
>  if (graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE) {

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] xenconfig: fix xml conversion convert with no graphics

[Joao Martins]

If no graphics element is in XML xenFormatXLSpice will access
graphics without checking it has one in the first place, leading to a
segmentation fault.

Signed-off-by: Joao Martins 
---
 src/xenconfig/xen_xl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c
index 2c9174e..74f68b3 100644
--- a/src/xenconfig/xen_xl.c
+++ b/src/xenconfig/xen_xl.c
@@ -1168,7 +1168,7 @@ xenFormatXLSpice(virConfPtr conf, virDomainDefPtr def)
 virDomainGraphicsListenDefPtr glisten;
 virDomainGraphicsDefPtr graphics;
 
-if (def->os.type == VIR_DOMAIN_OSTYPE_HVM) {
+if (def->os.type == VIR_DOMAIN_OSTYPE_HVM && def->graphics) {
 graphics = def->graphics[0];
 
 if (graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE) {
-- 
2.1.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list