Re: [libvirt] [PATCH 0/2] Sanitize header file conditionals and layout
On 12/13/18 5:26 PM, Daniel P. Berrangé wrote: > This series was inspired by the cleanup proposed by Michal in his recent > security driver work. I pointed out the mess he was cleaning up was in > fact across the entire codebase: > > https://www.redhat.com/archives/libvir-list/2018-December/msg00136.html > > This series addresses it globally > > Daniel P. Berrangé (2): > Fix many mistakes & inconsistencies in header file layout > Enforce a standard header file guard symbol name Thanks for taking care of this. ACK Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH 0/2] Sanitize header file conditionals and layout
This series was inspired by the cleanup proposed by Michal in his recent security driver work. I pointed out the mess he was cleaning up was in fact across the entire codebase: https://www.redhat.com/archives/libvir-list/2018-December/msg00136.html This series addresses it globally Daniel P. Berrangé (2): Fix many mistakes & inconsistencies in header file layout Enforce a standard header file guard symbol name build-aux/header-ifdef.pl | 156 cfg.mk | 7 +- docs/apibuild.py| 2 + include/libvirt/libvirt-admin.h | 6 +- include/libvirt/libvirt-domain-snapshot.h | 6 +- include/libvirt/libvirt-domain.h| 6 +- include/libvirt/libvirt-event.h | 6 +- include/libvirt/libvirt-host.h | 6 +- include/libvirt/libvirt-interface.h | 6 +- include/libvirt/libvirt-lxc.h | 6 +- include/libvirt/libvirt-network.h | 6 +- include/libvirt/libvirt-nodedev.h | 6 +- include/libvirt/libvirt-nwfilter.h | 6 +- include/libvirt/libvirt-qemu.h | 6 +- include/libvirt/libvirt-secret.h| 6 +- include/libvirt/libvirt-storage.h | 6 +- include/libvirt/libvirt-stream.h| 6 +- include/libvirt/libvirt.h | 6 +- include/libvirt/virterror.h | 6 +- src/access/viraccessdriver.h| 6 +- src/access/viraccessdrivernop.h | 6 +- src/access/viraccessdriverpolkit.h | 6 +- src/access/viraccessdriverstack.h | 6 +- src/access/viraccessmanager.h | 6 +- src/access/viraccessperm.h | 6 +- src/admin/admin_server.h| 6 +- src/admin/admin_server_dispatch.h | 6 +- src/bhyve/bhyve_capabilities.h | 6 +- src/bhyve/bhyve_command.h | 6 +- src/bhyve/bhyve_conf.h | 6 +- src/bhyve/bhyve_device.h| 6 +- src/bhyve/bhyve_domain.h| 6 +- src/bhyve/bhyve_driver.h| 6 +- src/bhyve/bhyve_monitor.h | 6 +- src/bhyve/bhyve_parse_command.h | 6 +- src/bhyve/bhyve_process.h | 6 +- src/bhyve/bhyve_utils.h | 6 +- src/conf/capabilities.h | 6 +- src/conf/cpu_conf.h | 6 +- src/conf/device_conf.h | 6 +- src/conf/domain_addr.h | 6 +- src/conf/domain_audit.h | 6 +- src/conf/domain_capabilities.h | 6 +- src/conf/domain_conf.h | 6 +- src/conf/domain_event.h | 9 +- src/conf/domain_nwfilter.h | 7 +- src/conf/interface_conf.h | 6 +- src/conf/netdev_bandwidth_conf.h| 6 +- src/conf/netdev_vlan_conf.h | 6 +- src/conf/netdev_vport_profile_conf.h| 6 +- src/conf/network_conf.h | 6 +- src/conf/network_event.h| 12 +- src/conf/networkcommon_conf.h | 6 +- src/conf/node_device_conf.h | 6 +- src/conf/node_device_event.h| 12 +- src/conf/node_device_util.h | 6 +- src/conf/numa_conf.h| 6 +- src/conf/nwfilter_conf.h| 7 +- src/conf/nwfilter_ipaddrmap.h | 6 +- src/conf/nwfilter_params.h | 7 +- src/conf/object_event.h | 10 +- src/conf/object_event_private.h | 8 +- src/conf/secret_conf.h | 7 +- src/conf/secret_event.h | 12 +- src/conf/snapshot_conf.h| 6 +- src/conf/storage_adapter_conf.h | 6 +- src/conf/storage_conf.h | 6 +- src/conf/storage_event.h| 12 +- src/conf/virchrdev.h| 8 +- src/conf/virdomainobjlist.h | 6 +- src/conf/virinterfaceobj.h | 6 +- src/conf/virnetworkobj.h| 6 +- src/conf/virnodedeviceobj.h | 6 +- src/conf/virnwfilterbindingdef.h| 7 +- src/conf/virnwfilterbindingobj.h| 7 +- src/conf/virnwfilterbindingobjlist.h| 6 +- src/conf/virnwfilterobj.h | 7 +- src/conf/virsavecookie.h| 7 +- src/conf/virsecretobj.h | 6 +- src/conf/virstorageobj.h| 6 +- src/cpu/cpu.h | 6 +- src/cpu/cpu_arm.h | 6 +- src/cpu/cpu_map.h | 6 +- src/cpu/cpu_ppc64.h | 6 +-
