Re: [libvirt] [PATCH 0/3] use virStringParseYesNo helper
On 10/16/19 3:51 PM, Andrea Bolognani wrote: On Wed, 2019-10-16 at 10:39 +0800, Mao Zhongyi wrote: A function virStringParseYesNo was added to convert string 'yes' to true and 'no' to false, so use this helper to replace 'STREQ(.*, \"yes\")' and 'STREQ(.*, \"no\")' as it allows us to drop several repetitive if-then-else string->bool conversion blocks. Cc: abolo...@redhat.com Cc: berra...@redhat.com Cc: crobi...@redhat.com Cc: g...@czarc.net Cc: g.sho1...@gmail.com Cc: jdene...@redhat.com Cc: la...@laine.org Cc: mklet...@redhat.com Cc: phrd...@redhat.com Please do *not* CC random libvirt developer when sending patches to the list: we are all subscribed, and someone will get to your patches eventually; if you haven't gotten any replies after two weeks or so, then it's perfectly fine to ping but once again do that on the list, not targeting specific individuals. Ok, I got it, thanks for the clarification. Thanks, Mao -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] use virStringParseYesNo helper
On Wed, 2019-10-16 at 10:39 +0800, Mao Zhongyi wrote: > A function virStringParseYesNo was added to convert > string 'yes' to true and 'no' to false, so use this > helper to replace 'STREQ(.*, \"yes\")' and > 'STREQ(.*, \"no\")' as it allows us to drop several > repetitive if-then-else string->bool conversion blocks. > > Cc: abolo...@redhat.com > Cc: berra...@redhat.com > Cc: crobi...@redhat.com > Cc: g...@czarc.net > Cc: g.sho1...@gmail.com > Cc: jdene...@redhat.com > Cc: la...@laine.org > Cc: mklet...@redhat.com > Cc: phrd...@redhat.com Please do *not* CC random libvirt developer when sending patches to the list: we are all subscribed, and someone will get to your patches eventually; if you haven't gotten any replies after two weeks or so, then it's perfectly fine to ping but once again do that on the list, not targeting specific individuals. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH 0/3] use virStringParseYesNo helper
A function virStringParseYesNo was added to convert string 'yes' to true and 'no' to false, so use this helper to replace 'STREQ(.*, \"yes\")' and 'STREQ(.*, \"no\")' as it allows us to drop several repetitive if-then-else string->bool conversion blocks. Cc: abolo...@redhat.com Cc: berra...@redhat.com Cc: crobi...@redhat.com Cc: g...@czarc.net Cc: g.sho1...@gmail.com Cc: jdene...@redhat.com Cc: la...@laine.org Cc: mklet...@redhat.com Cc: phrd...@redhat.com Mao Zhongyi (3): conf/domain_conf: use virStringParseYesNo helper conf/network_conf: use virStringParseYesNo helper qemu/qemu_migration_params: use virStringParseYesNo helper src/conf/domain_conf.c | 30 ++ src/conf/network_conf.c | 4 +--- src/qemu/qemu_migration_params.c | 6 +- 3 files changed, 16 insertions(+), 24 deletions(-) -- 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
