Re: [libvirt] [PATCH 0/7] Adjustments for storage/qemu volume/file backing size settings

2016-12-02 Thread Michal Privoznik
On 02.12.2016 01:39, John Ferlan wrote:
> A bit of a mix between fixing some bugs and merging some code between
> the block info/stats fetching of backing store data and storage backend
> data for volume allocation, capacity, and physical sizes.
> 
> Patch 1 just adjusts some comments
> 
> Patches 2-3 are code motion
> 
> Patch 4 alters how domain/qemu will open the backing store from an open
> to a qemuFileOpen and it allows for fetching of more physical sizes (the
> code only gets the block backing stores now)
> 
> Patch 5 shares the setting of the various size values between storage driver
> and domain/qemu
> 
> Patch 6 shares the recalculation of the capacity value (it may not be 
> necessary
> for patch 5, but I left it there since there's multiple other paths to the
> VolTargetInfoFD API).
> 
> Patch 7 fixes an issue with displaying the allocation value of a qcow2 backed
> file for the GetBlockInfo API (the results will match volume code now).
> 
> 
> John Ferlan (7):
>   qemu: Clean up description for qemuStorageLimitsRefresh
>   qemu: Add helpers to handle stat data for qemuStorageLimitsRefresh
>   qemu: Introduce helper qemuDomainStorageUpdatePhysical
>   util: Introduce virStorageSourceUpdatePhysicalSize
>   util: Introduce virStorageSourceUpdateBackingSizes
>   util: Introduce virStorageSourceUpdateCapacity
>   qemu: Fix GetBlockInfo setting allocation from wr_highest_offset
> 
>  src/libvirt_private.syms  |   5 +-
>  src/qemu/qemu_driver.c| 237 
> --
>  src/storage/storage_backend.c |  41 +---
>  src/util/virstoragefile.c | 173 ++
>  src/util/virstoragefile.h |  15 ++-
>  5 files changed, 304 insertions(+), 167 deletions(-)
> 

ACK but I suggest postponing the push after the release.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH 0/7] Adjustments for storage/qemu volume/file backing size settings

2016-12-01 Thread John Ferlan
A bit of a mix between fixing some bugs and merging some code between
the block info/stats fetching of backing store data and storage backend
data for volume allocation, capacity, and physical sizes.

Patch 1 just adjusts some comments

Patches 2-3 are code motion

Patch 4 alters how domain/qemu will open the backing store from an open
to a qemuFileOpen and it allows for fetching of more physical sizes (the
code only gets the block backing stores now)

Patch 5 shares the setting of the various size values between storage driver
and domain/qemu

Patch 6 shares the recalculation of the capacity value (it may not be necessary
for patch 5, but I left it there since there's multiple other paths to the
VolTargetInfoFD API).

Patch 7 fixes an issue with displaying the allocation value of a qcow2 backed
file for the GetBlockInfo API (the results will match volume code now).


John Ferlan (7):
  qemu: Clean up description for qemuStorageLimitsRefresh
  qemu: Add helpers to handle stat data for qemuStorageLimitsRefresh
  qemu: Introduce helper qemuDomainStorageUpdatePhysical
  util: Introduce virStorageSourceUpdatePhysicalSize
  util: Introduce virStorageSourceUpdateBackingSizes
  util: Introduce virStorageSourceUpdateCapacity
  qemu: Fix GetBlockInfo setting allocation from wr_highest_offset

 src/libvirt_private.syms  |   5 +-
 src/qemu/qemu_driver.c| 237 --
 src/storage/storage_backend.c |  41 +---
 src/util/virstoragefile.c | 173 ++
 src/util/virstoragefile.h |  15 ++-
 5 files changed, 304 insertions(+), 167 deletions(-)

-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list