Re: [libvirt] [PATCH 04/11] conf: Rename virDomainPCIAddressSet.areMultipleRootsSupported

[John Ferlan]

On 03/28/2018 10:06 AM, Andrea Bolognani wrote:
> We're going to add a similarly-named attribute later, and we'd
> like to be consistent.
> 
> Signed-off-by: Andrea Bolognani 
> ---
>  src/conf/domain_addr.c | 2 +-
>  src/conf/domain_addr.h | 2 +-
>  src/qemu/qemu_domain_address.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 

Reviewed-by: John Ferlan 

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 04/11] conf: Rename virDomainPCIAddressSet.areMultipleRootsSupported

[Andrea Bolognani]

We're going to add a similarly-named attribute later, and we'd
like to be consistent.

Signed-off-by: Andrea Bolognani 
---
 src/conf/domain_addr.c | 2 +-
 src/conf/domain_addr.h | 2 +-
 src/qemu/qemu_domain_address.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index 18b6f8d588..e02d7ac614 100644
--- a/src/conf/domain_addr.c
+++ b/src/conf/domain_addr.c
@@ -413,7 +413,7 @@ virDomainPCIAddressSetGrow(virDomainPCIAddressSetPtr addrs,
  */
 
 if (flags & VIR_PCI_CONNECT_TYPE_PCI_DEVICE) {
-if (addrs->multipleRootsSupported) {
+if (addrs->areMultipleRootsSupported) {
 /* Use a pci-root controller to expand the guest's PCI
  * topology if it supports having more than one */
 model = VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT;
diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h
index d3541bab09..87986c2bb7 100644
--- a/src/conf/domain_addr.h
+++ b/src/conf/domain_addr.h
@@ -115,7 +115,7 @@ struct _virDomainPCIAddressSet {
 bool dryRun;  /* on a dry run, new buses are auto-added
  and addresses aren't saved in device infos */
 /* If true, the guest can have multiple pci-root controllers */
-bool multipleRootsSupported;
+bool areMultipleRootsSupported;
 };
 typedef struct _virDomainPCIAddressSet virDomainPCIAddressSet;
 typedef virDomainPCIAddressSet *virDomainPCIAddressSetPtr;
diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index 37473ebf13..40fb540adc 100644
--- a/src/qemu/qemu_domain_address.c
+++ b/src/qemu/qemu_domain_address.c
@@ -1353,7 +1353,7 @@ qemuDomainPCIAddressSetCreate(virDomainDefPtr def,
 
 /* pSeries domains support multiple pci-root controllers */
 if (qemuDomainIsPSeries(def))
-addrs->multipleRootsSupported = true;
+addrs->areMultipleRootsSupported = true;
 
 for (i = 0; i < def->ncontrollers; i++) {
 virDomainControllerDefPtr cont = def->controllers[i];
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list