Re: [libvirt] [PATCH 1/6] qemu: capabilities: Always assume QEMU_CAPS_BOOTINDEX
On Thu, Aug 09, 2018 at 16:34:56 +0200, Ján Tomko wrote: > On Thu, Aug 09, 2018 at 02:48:54PM +0200, Peter Krempa wrote: > > The field was added in qemu v0.13.0-rc0-731-g1ca4d09ae0 so all supported > > qemu versions now use it. > > > > There's a LOT of test fallout as we did not use capabilities close > > enough to upstream for many of our tests. > > > > Signed-off-by: Peter Krempa > > --- > > Actually, you can also remove these files, since their non-bootindex > variants will replace them: > > tests/qemuxml2argvdata/boot-complex-bootindex.args| 48 > - > tests/qemuxml2argvdata/boot-complex-bootindex.xml | 66 > > tests/qemuxml2argvdata/boot-menu-disable-drive-bootindex.args | 29 > - > tests/qemuxml2argvdata/boot-menu-disable-drive-bootindex.xml | 28 > > tests/qemuxml2argvdata/boot-menu-enable-bootindex.args| 29 > - > tests/qemuxml2argvdata/boot-menu-enable-bootindex.xml | 28 > > tests/qemuxml2argvdata/bootindex-floppy-q35.args | 24 > - > tests/qemuxml2argvdata/bootindex-floppy-q35.xml | 32 > --- > tests/qemuxml2xmloutdata/bootindex-floppy-q35.xml | 32 > Thanks! I've squashed these into the commit and pushed the series. signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/6] qemu: capabilities: Always assume QEMU_CAPS_BOOTINDEX
On Thu, Aug 09, 2018 at 02:48:54PM +0200, Peter Krempa wrote: The field was added in qemu v0.13.0-rc0-731-g1ca4d09ae0 so all supported qemu versions now use it. There's a LOT of test fallout as we did not use capabilities close enough to upstream for many of our tests. Signed-off-by: Peter Krempa --- Actually, you can also remove these files, since their non-bootindex variants will replace them: tests/qemuxml2argvdata/boot-complex-bootindex.args| 48 - tests/qemuxml2argvdata/boot-complex-bootindex.xml | 66 tests/qemuxml2argvdata/boot-menu-disable-drive-bootindex.args | 29 - tests/qemuxml2argvdata/boot-menu-disable-drive-bootindex.xml | 28 tests/qemuxml2argvdata/boot-menu-enable-bootindex.args| 29 - tests/qemuxml2argvdata/boot-menu-enable-bootindex.xml | 28 tests/qemuxml2argvdata/bootindex-floppy-q35.args | 24 - tests/qemuxml2argvdata/bootindex-floppy-q35.xml | 32 --- tests/qemuxml2xmloutdata/bootindex-floppy-q35.xml | 32 Jano signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/6] qemu: capabilities: Always assume QEMU_CAPS_BOOTINDEX
On Thu, Aug 09, 2018 at 02:48:54PM +0200, Peter Krempa wrote: The field was added in qemu v0.13.0-rc0-731-g1ca4d09ae0 so all supported qemu versions now use it. There's a LOT of test fallout as we did not use capabilities close enough to upstream for many of our tests. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 4 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c| 96 +- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - [...] tests/qemuxml2argvdata/watchdog-injectnmi.args | 4 +- tests/qemuxml2argvdata/watchdog.args | 4 +- tests/qemuxml2argvdata/x86-kvm-32-on-64.args | 3 +- tests/qemuxml2argvtest.c | 39 +++-- tests/qemuxml2xmltest.c| 5 +- 597 files changed, 691 insertions(+), 1076 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
