Re: [libvirt] [PATCH 1/8] conf: domcaps: Add 'backingStoreInput' domain capability

2019-11-22 Thread Daniel P . Berrangé
On Fri, Nov 22, 2019 at 10:18:02AM +0100, Peter Krempa wrote:
> On Thu, Nov 21, 2019 at 18:19:55 +, Daniel Berrange wrote:
> > On Mon, Nov 18, 2019 at 06:02:01PM +0100, Peter Krempa wrote:
> > > Historically we've only supported the  as an output-only
> > > element for domain disks. The documentation states that it may become
> > > supported on input. To allow management apps detectin once that happens
> > 
> > s/detectin/to detect/
> > 
> > > add a domain capability which will be asserted if the hypervisor driver
> > > will be able to obey the  as configured on input.
> > > 
> > > Signed-off-by: Peter Krempa 
> > > ---
> > >  docs/formatdomaincaps.html.in | 7 +++
> > >  docs/schemas/domaincaps.rng   | 9 +
> > >  src/conf/domain_capabilities.c| 1 +
> > >  src/conf/domain_capabilities.h| 1 +
> > >  tests/domaincapsdata/libxl-xenfv.xml  | 1 +
> > >  tests/domaincapsdata/libxl-xenpv.xml  | 1 +
> > >  tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_1.5.3-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_1.5.3.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_1.6.0-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_1.6.0-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_1.6.0.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_1.7.0-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_1.7.0-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_1.7.0.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.1.1-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.1.1-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.1.1.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.10.0-q35.x86_64.xml   | 1 +
> > >  tests/domaincapsdata/qemu_2.10.0-tcg.x86_64.xml   | 1 +
> > >  tests/domaincapsdata/qemu_2.10.0-virt.aarch64.xml | 1 +
> > >  tests/domaincapsdata/qemu_2.10.0.aarch64.xml  | 1 +
> > >  tests/domaincapsdata/qemu_2.10.0.ppc64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.10.0.s390x.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.10.0.x86_64.xml   | 1 +
> > >  tests/domaincapsdata/qemu_2.11.0-q35.x86_64.xml   | 1 +
> > >  tests/domaincapsdata/qemu_2.11.0-tcg.x86_64.xml   | 1 +
> > >  tests/domaincapsdata/qemu_2.11.0.s390x.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.11.0.x86_64.xml   | 1 +
> > >  tests/domaincapsdata/qemu_2.12.0-q35.x86_64.xml   | 1 +
> > >  tests/domaincapsdata/qemu_2.12.0-tcg.x86_64.xml   | 1 +
> > >  tests/domaincapsdata/qemu_2.12.0-virt.aarch64.xml | 1 +
> > >  tests/domaincapsdata/qemu_2.12.0.aarch64.xml  | 1 +
> > >  tests/domaincapsdata/qemu_2.12.0.ppc64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.12.0.s390x.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.12.0.x86_64.xml   | 1 +
> > >  tests/domaincapsdata/qemu_2.4.0-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.4.0-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.4.0.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.5.0-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.5.0-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.5.0.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.6.0-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.6.0-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.6.0-virt.aarch64.xml  | 1 +
> > >  tests/domaincapsdata/qemu_2.6.0.aarch64.xml   | 1 +
> > >  tests/domaincapsdata/qemu_2.6.0.ppc64.xml | 1 +
> > >  tests/domaincapsdata/qemu_2.6.0.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.7.0-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.7.0-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 +
> > >  tests/domaincapsdata/qemu_2.7.0.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.8.0-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.8.0-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 +
> > >  tests/domaincapsdata/qemu_2.8.0.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.9.0-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.9.0-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_2.9.0.ppc64.xml | 1 +
> > >  tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 +
> > >  tests/domaincapsdata/qemu_2.9.0.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_3.0.0-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_3.0.0-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 +
> > >  tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 +
> > >  tests/domaincapsdata/qemu_3.0.0.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml| 1 +
> > >  tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 +
> > > 

Re: [libvirt] [PATCH 1/8] conf: domcaps: Add 'backingStoreInput' domain capability

2019-11-22 Thread Peter Krempa
On Thu, Nov 21, 2019 at 18:19:55 +, Daniel Berrange wrote:
> On Mon, Nov 18, 2019 at 06:02:01PM +0100, Peter Krempa wrote:
> > Historically we've only supported the  as an output-only
> > element for domain disks. The documentation states that it may become
> > supported on input. To allow management apps detectin once that happens
> 
> s/detectin/to detect/
> 
> > add a domain capability which will be asserted if the hypervisor driver
> > will be able to obey the  as configured on input.
> > 
> > Signed-off-by: Peter Krempa 
> > ---
> >  docs/formatdomaincaps.html.in | 7 +++
> >  docs/schemas/domaincaps.rng   | 9 +
> >  src/conf/domain_capabilities.c| 1 +
> >  src/conf/domain_capabilities.h| 1 +
> >  tests/domaincapsdata/libxl-xenfv.xml  | 1 +
> >  tests/domaincapsdata/libxl-xenpv.xml  | 1 +
> >  tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_1.5.3-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_1.5.3.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_1.6.0-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_1.6.0-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_1.6.0.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_1.7.0-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_1.7.0-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_1.7.0.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.1.1-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.1.1-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.1.1.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.10.0-q35.x86_64.xml   | 1 +
> >  tests/domaincapsdata/qemu_2.10.0-tcg.x86_64.xml   | 1 +
> >  tests/domaincapsdata/qemu_2.10.0-virt.aarch64.xml | 1 +
> >  tests/domaincapsdata/qemu_2.10.0.aarch64.xml  | 1 +
> >  tests/domaincapsdata/qemu_2.10.0.ppc64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.10.0.s390x.xml| 1 +
> >  tests/domaincapsdata/qemu_2.10.0.x86_64.xml   | 1 +
> >  tests/domaincapsdata/qemu_2.11.0-q35.x86_64.xml   | 1 +
> >  tests/domaincapsdata/qemu_2.11.0-tcg.x86_64.xml   | 1 +
> >  tests/domaincapsdata/qemu_2.11.0.s390x.xml| 1 +
> >  tests/domaincapsdata/qemu_2.11.0.x86_64.xml   | 1 +
> >  tests/domaincapsdata/qemu_2.12.0-q35.x86_64.xml   | 1 +
> >  tests/domaincapsdata/qemu_2.12.0-tcg.x86_64.xml   | 1 +
> >  tests/domaincapsdata/qemu_2.12.0-virt.aarch64.xml | 1 +
> >  tests/domaincapsdata/qemu_2.12.0.aarch64.xml  | 1 +
> >  tests/domaincapsdata/qemu_2.12.0.ppc64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.12.0.s390x.xml| 1 +
> >  tests/domaincapsdata/qemu_2.12.0.x86_64.xml   | 1 +
> >  tests/domaincapsdata/qemu_2.4.0-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.4.0-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.4.0.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.5.0-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.5.0-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.5.0.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.6.0-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.6.0-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.6.0-virt.aarch64.xml  | 1 +
> >  tests/domaincapsdata/qemu_2.6.0.aarch64.xml   | 1 +
> >  tests/domaincapsdata/qemu_2.6.0.ppc64.xml | 1 +
> >  tests/domaincapsdata/qemu_2.6.0.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.7.0-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.7.0-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 +
> >  tests/domaincapsdata/qemu_2.7.0.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.8.0-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.8.0-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 +
> >  tests/domaincapsdata/qemu_2.8.0.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.9.0-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.9.0-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_2.9.0.ppc64.xml | 1 +
> >  tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 +
> >  tests/domaincapsdata/qemu_2.9.0.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_3.0.0-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_3.0.0-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 +
> >  tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 +
> >  tests/domaincapsdata/qemu_3.0.0.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 +
> >  tests/domaincapsdata/qemu_3.1.0.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml| 1 +
> >  tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml| 1 +
> >  

Re: [libvirt] [PATCH 1/8] conf: domcaps: Add 'backingStoreInput' domain capability

2019-11-21 Thread Daniel P . Berrangé
On Mon, Nov 18, 2019 at 06:02:01PM +0100, Peter Krempa wrote:
> Historically we've only supported the  as an output-only
> element for domain disks. The documentation states that it may become
> supported on input. To allow management apps detectin once that happens

s/detectin/to detect/

> add a domain capability which will be asserted if the hypervisor driver
> will be able to obey the  as configured on input.
> 
> Signed-off-by: Peter Krempa 
> ---
>  docs/formatdomaincaps.html.in | 7 +++
>  docs/schemas/domaincaps.rng   | 9 +
>  src/conf/domain_capabilities.c| 1 +
>  src/conf/domain_capabilities.h| 1 +
>  tests/domaincapsdata/libxl-xenfv.xml  | 1 +
>  tests/domaincapsdata/libxl-xenpv.xml  | 1 +
>  tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_1.5.3-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_1.5.3.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_1.6.0-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_1.6.0-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_1.6.0.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_1.7.0-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_1.7.0-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_1.7.0.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.1.1-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.1.1-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.1.1.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.10.0-q35.x86_64.xml   | 1 +
>  tests/domaincapsdata/qemu_2.10.0-tcg.x86_64.xml   | 1 +
>  tests/domaincapsdata/qemu_2.10.0-virt.aarch64.xml | 1 +
>  tests/domaincapsdata/qemu_2.10.0.aarch64.xml  | 1 +
>  tests/domaincapsdata/qemu_2.10.0.ppc64.xml| 1 +
>  tests/domaincapsdata/qemu_2.10.0.s390x.xml| 1 +
>  tests/domaincapsdata/qemu_2.10.0.x86_64.xml   | 1 +
>  tests/domaincapsdata/qemu_2.11.0-q35.x86_64.xml   | 1 +
>  tests/domaincapsdata/qemu_2.11.0-tcg.x86_64.xml   | 1 +
>  tests/domaincapsdata/qemu_2.11.0.s390x.xml| 1 +
>  tests/domaincapsdata/qemu_2.11.0.x86_64.xml   | 1 +
>  tests/domaincapsdata/qemu_2.12.0-q35.x86_64.xml   | 1 +
>  tests/domaincapsdata/qemu_2.12.0-tcg.x86_64.xml   | 1 +
>  tests/domaincapsdata/qemu_2.12.0-virt.aarch64.xml | 1 +
>  tests/domaincapsdata/qemu_2.12.0.aarch64.xml  | 1 +
>  tests/domaincapsdata/qemu_2.12.0.ppc64.xml| 1 +
>  tests/domaincapsdata/qemu_2.12.0.s390x.xml| 1 +
>  tests/domaincapsdata/qemu_2.12.0.x86_64.xml   | 1 +
>  tests/domaincapsdata/qemu_2.4.0-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.4.0-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.4.0.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.5.0-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.5.0-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.5.0.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.6.0-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.6.0-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.6.0-virt.aarch64.xml  | 1 +
>  tests/domaincapsdata/qemu_2.6.0.aarch64.xml   | 1 +
>  tests/domaincapsdata/qemu_2.6.0.ppc64.xml | 1 +
>  tests/domaincapsdata/qemu_2.6.0.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.7.0-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.7.0-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 +
>  tests/domaincapsdata/qemu_2.7.0.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.8.0-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.8.0-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 +
>  tests/domaincapsdata/qemu_2.8.0.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.9.0-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.9.0-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_2.9.0.ppc64.xml | 1 +
>  tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 +
>  tests/domaincapsdata/qemu_2.9.0.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_3.0.0-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_3.0.0-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 +
>  tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 +
>  tests/domaincapsdata/qemu_3.0.0.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 +
>  tests/domaincapsdata/qemu_3.1.0.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml| 1 +
>  tests/domaincapsdata/qemu_4.0.0-virt.aarch64.xml  | 1 +
>  tests/domaincapsdata/qemu_4.0.0.aarch64.xml   | 1 +
>  tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 +
>  tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 +
>  

Re: [libvirt] [PATCH 1/8] conf: domcaps: Add 'backingStoreInput' domain capability

2019-11-20 Thread Peter Krempa
On Mon, Nov 18, 2019 at 14:54:50 -0500, Cole Robinson wrote:
> On 11/18/19 12:02 PM, Peter Krempa wrote:
> > Historically we've only supported the  as an output-only
> > element for domain disks. The documentation states that it may become
> > supported on input. To allow management apps detectin once that happens
> > add a domain capability which will be asserted if the hypervisor driver
> > will be able to obey the  as configured on input.
> > 
> > Signed-off-by: Peter Krempa 
> > ---
> >  docs/formatdomaincaps.html.in | 7 +++
> >  docs/schemas/domaincaps.rng   | 9 +
> >  src/conf/domain_capabilities.c| 1 +
> >  src/conf/domain_capabilities.h| 1 +
> >  tests/domaincapsdata/libxl-xenfv.xml  | 1 +
> >  tests/domaincapsdata/libxl-xenpv.xml  | 1 +
> 
> Now that I look closer, this patch illustrates one of the issues with
> the pattern of virDomainCapsFeaturesInitUnsupported : that function is
> used in the bhyve driver, but this patch doesn't update the bhyve test
> suite domcaps output. devs can't add a new domcaps feature without
> having to regenerate test output for every driver, which is a pain and
> easy to overlook.

It illustrates my counter-point nicely too. I'd not bother to turn off
the capability in bhyve despite it being unsupported. Now at least the
tests caught it.



signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1/8] conf: domcaps: Add 'backingStoreInput' domain capability

2019-11-18 Thread Cole Robinson
On 11/18/19 12:02 PM, Peter Krempa wrote:
> Historically we've only supported the  as an output-only
> element for domain disks. The documentation states that it may become
> supported on input. To allow management apps detectin once that happens
> add a domain capability which will be asserted if the hypervisor driver
> will be able to obey the  as configured on input.
> 
> Signed-off-by: Peter Krempa 
> ---
>  docs/formatdomaincaps.html.in | 7 +++
>  docs/schemas/domaincaps.rng   | 9 +
>  src/conf/domain_capabilities.c| 1 +
>  src/conf/domain_capabilities.h| 1 +
>  tests/domaincapsdata/libxl-xenfv.xml  | 1 +
>  tests/domaincapsdata/libxl-xenpv.xml  | 1 +

Now that I look closer, this patch illustrates one of the issues with
the pattern of virDomainCapsFeaturesInitUnsupported : that function is
used in the bhyve driver, but this patch doesn't update the bhyve test
suite domcaps output. devs can't add a new domcaps feature without
having to regenerate test output for every driver, which is a pain and
easy to overlook.

Thanks,
Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list



[libvirt] [PATCH 1/8] conf: domcaps: Add 'backingStoreInput' domain capability

2019-11-18 Thread Peter Krempa
Historically we've only supported the  as an output-only
element for domain disks. The documentation states that it may become
supported on input. To allow management apps detectin once that happens
add a domain capability which will be asserted if the hypervisor driver
will be able to obey the  as configured on input.

Signed-off-by: Peter Krempa 
---
 docs/formatdomaincaps.html.in | 7 +++
 docs/schemas/domaincaps.rng   | 9 +
 src/conf/domain_capabilities.c| 1 +
 src/conf/domain_capabilities.h| 1 +
 tests/domaincapsdata/libxl-xenfv.xml  | 1 +
 tests/domaincapsdata/libxl-xenpv.xml  | 1 +
 tests/domaincapsdata/qemu_1.5.3-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_1.5.3-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_1.5.3.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_1.6.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_1.6.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_1.6.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_1.7.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_1.7.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_1.7.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.1.1-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.1.1-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.1.1.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.10.0-q35.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.10.0-tcg.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.10.0-virt.aarch64.xml | 1 +
 tests/domaincapsdata/qemu_2.10.0.aarch64.xml  | 1 +
 tests/domaincapsdata/qemu_2.10.0.ppc64.xml| 1 +
 tests/domaincapsdata/qemu_2.10.0.s390x.xml| 1 +
 tests/domaincapsdata/qemu_2.10.0.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.11.0-q35.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.11.0-tcg.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.11.0.s390x.xml| 1 +
 tests/domaincapsdata/qemu_2.11.0.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.12.0-q35.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.12.0-tcg.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.12.0-virt.aarch64.xml | 1 +
 tests/domaincapsdata/qemu_2.12.0.aarch64.xml  | 1 +
 tests/domaincapsdata/qemu_2.12.0.ppc64.xml| 1 +
 tests/domaincapsdata/qemu_2.12.0.s390x.xml| 1 +
 tests/domaincapsdata/qemu_2.12.0.x86_64.xml   | 1 +
 tests/domaincapsdata/qemu_2.4.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.4.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.4.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.5.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.5.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.5.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.6.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.6.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.6.0-virt.aarch64.xml  | 1 +
 tests/domaincapsdata/qemu_2.6.0.aarch64.xml   | 1 +
 tests/domaincapsdata/qemu_2.6.0.ppc64.xml | 1 +
 tests/domaincapsdata/qemu_2.6.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.7.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.7.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 +
 tests/domaincapsdata/qemu_2.7.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.8.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.8.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 +
 tests/domaincapsdata/qemu_2.8.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.9.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.9.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_2.9.0.ppc64.xml | 1 +
 tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 +
 tests/domaincapsdata/qemu_2.9.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_3.0.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_3.0.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 +
 tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 +
 tests/domaincapsdata/qemu_3.0.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_3.1.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_3.1.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 +
 tests/domaincapsdata/qemu_3.1.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_4.0.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_4.0.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_4.0.0-virt.aarch64.xml  | 1 +
 tests/domaincapsdata/qemu_4.0.0.aarch64.xml   | 1 +
 tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 +
 tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 +
 tests/domaincapsdata/qemu_4.0.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_4.1.0.x86_64.xml| 1 +
 tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml| 1 +