Re: [libvirt] [PATCH 15/42] qemu: Don't check the output of virGetUserCacheDirectory()

2019-12-19 Thread Ján Tomko 

On Thu, Dec 19, 2019 at 11:04:20AM +0100, Fabiano Fidêncio wrote:

virGetUserCacheDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio 
---
src/qemu/qemu_conf.c | 2 --
1 file changed, 2 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 15/42] qemu: Don't check the output of virGetUserCacheDirectory()

2019-12-19 Thread Fabiano Fidêncio 
virGetUserCacheDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio 
---
 src/qemu/qemu_conf.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 389ac55bee..634c65095e 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -165,8 +165,6 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool 
privileged)
 g_autofree char *cachedir = NULL;
 
 cachedir = virGetUserCacheDirectory();
-if (!cachedir)
-return NULL;
 
 cfg->logDir = g_strdup_printf("%s/qemu/log", cachedir);
 cfg->swtpmLogDir = g_strdup_printf("%s/qemu/log", cachedir);
-- 
2.24.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list