Re: [libvirt] [PATCH 2/6] spec: Build virt-login-shell iff LXC driver is enabled

[Daniel P . Berrangé]

On Wed, Feb 14, 2018 at 03:11:37PM +0100, Jiri Denemark wrote:
> Building virt-login-shell doesn't really make any sense without LXC and
> doing so even breaks "make rpm" since the associated files are installed
> but unpackaged (the login-shell sub package already depends on LXC).
> 
> Signed-off-by: Jiri Denemark 
> ---
>  libvirt.spec.in | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 4821da826e..5d05acd620 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -1182,8 +1182,10 @@ exit 1
>  
>  %if %{with_lxc}
>  %define arg_lxc --with-lxc
> +%define arg_login_shell --with-login-shell
>  %else
>  %define arg_lxc --without-lxc
> +%define arg_login_shell --without-login-shell
>  %endif
>  
>  %if %{with_vbox}
> @@ -1393,7 +1395,8 @@ rm -f po/stamp-po
> %{?arg_loader_nvram} \
> %{?enable_werror} \
> --enable-expensive-tests \
> -   %{arg_init_script}
> +   %{arg_init_script} \
> +   %{?arg_login_shell}
>  make %{?_smp_mflags} V=1
>  gzip -9 ChangeLog

Reviewed-by: Daniel P. Berrangé 


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/6] spec: Build virt-login-shell iff LXC driver is enabled

[Jiri Denemark]

Building virt-login-shell doesn't really make any sense without LXC and
doing so even breaks "make rpm" since the associated files are installed
but unpackaged (the login-shell sub package already depends on LXC).

Signed-off-by: Jiri Denemark 
---
 libvirt.spec.in | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 4821da826e..5d05acd620 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1182,8 +1182,10 @@ exit 1
 
 %if %{with_lxc}
 %define arg_lxc --with-lxc
+%define arg_login_shell --with-login-shell
 %else
 %define arg_lxc --without-lxc
+%define arg_login_shell --without-login-shell
 %endif
 
 %if %{with_vbox}
@@ -1393,7 +1395,8 @@ rm -f po/stamp-po
%{?arg_loader_nvram} \
%{?enable_werror} \
--enable-expensive-tests \
-   %{arg_init_script}
+   %{arg_init_script} \
+   %{?arg_login_shell}
 make %{?_smp_mflags} V=1
 gzip -9 ChangeLog
 
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list