Re: [libvirt] [PATCH 4/5] qemu: Support topological visits

2019-03-12 Thread Daniel P . Berrangé 
On Fri, Mar 08, 2019 at 12:05:11AM -0600, Eric Blake wrote:
> snapshot_conf does all the hard work, the qemu driver just has to
> accept the new flag.
> 
> Signed-off-by: Eric Blake 
> ---
>  src/qemu/qemu_driver.c | 6 ++
>  1 file changed, 6 insertions(+)

Reviewed-by: Daniel P. Berrangé 


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 4/5] qemu: Support topological visits

2019-03-12 Thread Ján Tomko 

On Fri, Mar 08, 2019 at 12:05:11AM -0600, Eric Blake wrote:

snapshot_conf does all the hard work, the qemu driver just has to
accept the new flag.

Signed-off-by: Eric Blake 
---
src/qemu/qemu_driver.c | 6 ++
1 file changed, 6 insertions(+)


Same here.


Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 4/5] qemu: Support topological visits

2019-03-07 Thread Eric Blake 
snapshot_conf does all the hard work, the qemu driver just has to
accept the new flag.

Signed-off-by: Eric Blake 
---
 src/qemu/qemu_driver.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 205e544d92..e461fb51b0 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -15972,6 +15972,7 @@ qemuDomainSnapshotListNames(virDomainPtr domain,
 int n = -1;

 virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_ROOTS |
+  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);

 if (!(vm = qemuDomObjFromDomain(domain)))
@@ -15997,6 +15998,7 @@ qemuDomainSnapshotNum(virDomainPtr domain,
 int n = -1;

 virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_ROOTS |
+  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);

 if (!(vm = qemuDomObjFromDomain(domain)))
@@ -16022,6 +16024,7 @@ qemuDomainListAllSnapshots(virDomainPtr domain,
 int n = -1;

 virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_ROOTS |
+  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);

 if (!(vm = qemuDomObjFromDomain(domain)))
@@ -16049,6 +16052,7 @@ 
qemuDomainSnapshotListChildrenNames(virDomainSnapshotPtr snapshot,
 int n = -1;

 virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_DESCENDANTS |
+  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);

 if (!(vm = qemuDomObjFromSnapshot(snapshot)))
@@ -16078,6 +16082,7 @@ qemuDomainSnapshotNumChildren(virDomainSnapshotPtr 
snapshot,
 int n = -1;

 virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_DESCENDANTS |
+  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);

 if (!(vm = qemuDomObjFromSnapshot(snapshot)))
@@ -16107,6 +16112,7 @@ qemuDomainSnapshotListAllChildren(virDomainSnapshotPtr 
snapshot,
 int n = -1;

 virCheckFlags(VIR_DOMAIN_SNAPSHOT_LIST_DESCENDANTS |
+  VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL |
   VIR_DOMAIN_SNAPSHOT_FILTERS_ALL, -1);

 if (!(vm = qemuDomObjFromSnapshot(snapshot)))
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list