Re: [libvirt] [PATCH 4/5] qemuMonitorCPUModelInfoFree: Don't leak model_info->props

[John Ferlan]

On 02/06/2017 03:21 AM, Michal Privoznik wrote:
> ==11846== 240 bytes in 1 blocks are definitely lost in loss record 81 of 107
> ==11846==at 0x4C2BC75: calloc (vg_replace_malloc.c:624)
> ==11846==by 0x18C74242: virAllocN (viralloc.c:191)
> ==11846==by 0x4A05E8: qemuMonitorCPUModelInfoCopy (qemu_monitor.c:3677)
> ==11846==by 0x446E3C: virQEMUCapsNewCopy (qemu_capabilities.c:2171)
> ==11846==by 0x437335: testQemuCapsCopy (qemucapabilitiestest.c:108)
> ==11846==by 0x437CD2: virTestRun (testutils.c:180)
> ==11846==by 0x437AD8: mymain (qemucapabilitiestest.c:176)
> ==11846==by 0x4397B6: virTestMain (testutils.c:992)
> ==11846==by 0x437B44: main (qemucapabilitiestest.c:188)
> 
> Signed-off-by: Michal Privoznik 
> ---
>  src/qemu/qemu_monitor.c | 1 +
>  1 file changed, 1 insertion(+)
> 

ACK

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 4/5] qemuMonitorCPUModelInfoFree: Don't leak model_info->props

[Michal Privoznik]

==11846== 240 bytes in 1 blocks are definitely lost in loss record 81 of 107
==11846==at 0x4C2BC75: calloc (vg_replace_malloc.c:624)
==11846==by 0x18C74242: virAllocN (viralloc.c:191)
==11846==by 0x4A05E8: qemuMonitorCPUModelInfoCopy (qemu_monitor.c:3677)
==11846==by 0x446E3C: virQEMUCapsNewCopy (qemu_capabilities.c:2171)
==11846==by 0x437335: testQemuCapsCopy (qemucapabilitiestest.c:108)
==11846==by 0x437CD2: virTestRun (testutils.c:180)
==11846==by 0x437AD8: mymain (qemucapabilitiestest.c:176)
==11846==by 0x4397B6: virTestMain (testutils.c:992)
==11846==by 0x437B44: main (qemucapabilitiestest.c:188)

Signed-off-by: Michal Privoznik 
---
 src/qemu/qemu_monitor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index b7be5e7f4..565339921 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -3660,6 +3660,7 @@ qemuMonitorCPUModelInfoFree(qemuMonitorCPUModelInfoPtr 
model_info)
 for (i = 0; i < model_info->nprops; i++)
 VIR_FREE(model_info->props[i].name);
 
+VIR_FREE(model_info->props);
 VIR_FREE(model_info->name);
 VIR_FREE(model_info);
 }
-- 
2.11.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list