Re: [libvirt] [PATCH 4/6] virsh: Resolve Coverity DEADCODE

2015-09-24 Thread John Ferlan 


On 09/24/2015 03:47 AM, Ján Tomko wrote:
> On Wed, Sep 23, 2015 at 07:18:31PM -0400, John Ferlan wrote:
>> Use 'dead_error_condition' instead of 'dead_error_begin'
>>
> 
> Just wondering - what is the difference?

Perhaps just the one condition and not a set of conditions or lines? Not
quite sure, but you know where to find the internal output and you'll
see the data spewed by Coverity about the deadcode.

> Doesn't dead_error_begin require a dead_error_end?

No - once it's dead, it's not coming back to life.

John

> 
>> Signed-off-by: John Ferlan 
>> ---
>>  tools/virsh.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> ACK.
> 
> Jan
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 4/6] virsh: Resolve Coverity DEADCODE

2015-09-24 Thread Ján Tomko 
On Wed, Sep 23, 2015 at 07:18:31PM -0400, John Ferlan wrote:
> Use 'dead_error_condition' instead of 'dead_error_begin'
> 

Just wondering - what is the difference?
Doesn't dead_error_begin require a dead_error_end?

> Signed-off-by: John Ferlan 
> ---
>  tools/virsh.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

ACK.

Jan


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 4/6] virsh: Resolve Coverity DEADCODE

2015-09-23 Thread John Ferlan 
Use 'dead_error_condition' instead of 'dead_error_begin'

Signed-off-by: John Ferlan 
---
 tools/virsh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index 76b5e9f..7484bed 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -118,7 +118,7 @@ virshCatchDisconnect(virConnectPtr conn,
 case VIR_CONNECT_CLOSE_REASON_KEEPALIVE:
 str = N_("Disconnected from %s due to keepalive timeout");
 break;
-/* coverity[dead_error_begin] */
+/* coverity[dead_error_condition] */
 case VIR_CONNECT_CLOSE_REASON_CLIENT:
 case VIR_CONNECT_CLOSE_REASON_LAST:
 break;
-- 
2.1.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list