Re: [libvirt] [PATCH 5/9] syntax-check: update of sprintf rule to mention g_snpritnf

2019-11-20 Thread Ján Tomko 

s/g_snpritnf/g_snprintf/

On Wed, Nov 20, 2019 at 12:42:05PM +0100, Peter Krempa wrote:

From: Pavel Hrdina 

Signed-off-by: Pavel Hrdina 
Reviewed-by: Peter Krempa 
---
build-aux/syntax-check.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



with that fixed:
Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 5/9] syntax-check: update of sprintf rule to mention g_snpritnf

2019-11-20 Thread Peter Krempa 
From: Pavel Hrdina 

Signed-off-by: Pavel Hrdina 
Reviewed-by: Peter Krempa 
---
 build-aux/syntax-check.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index ba941746a1..6b62e20ed4 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -475,11 +475,11 @@ sc_prohibit_risky_id_promotion:
halt='cast -1 to ([ug]id_t) before comparing against id' \
  $(_sc_search_regexp)

-# Use snprintf rather than s'printf, even if buffer is provably large enough,
+# Use g_snprintf rather than s'printf, even if buffer is provably large enough,
 # since gnulib has more guarantees for snprintf portability
 sc_prohibit_sprintf:
@prohibit='\<[s]printf\>' \
-   halt='use snprintf, not sprintf' \
+   halt='use g_snprintf, not sprintf' \
  $(_sc_search_regexp)

 sc_prohibit_readlink:
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list