Re: [libvirt] [PATCH V2 13/13] libxl: use job functions in libxlDomainSetSchedulerParametersFlags

[Daniel P. Berrange]

On Wed, Feb 12, 2014 at 06:56:27PM -0700, Jim Fehlig wrote:
 Modify operation that needs to wait in the queue of modify jobs.
 
 Signed-off-by: Jim Fehlig jfeh...@suse.com
 ---
 
 V2: Check libxlDomainObjEndJob() return value
 
  src/libxl/libxl_driver.c | 16 
  1 file changed, 12 insertions(+), 4 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH V2 13/13] libxl: use job functions in libxlDomainSetSchedulerParametersFlags

[Jim Fehlig]

Daniel P. Berrange wrote:
 On Wed, Feb 12, 2014 at 06:56:27PM -0700, Jim Fehlig wrote:
   
 Modify operation that needs to wait in the queue of modify jobs.

 Signed-off-by: Jim Fehlig jfeh...@suse.com
 ---

 V2: Check libxlDomainObjEndJob() return value

  src/libxl/libxl_driver.c | 16 
  1 file changed, 12 insertions(+), 4 deletions(-)
 

 ACK
   

Thanks for the reviews!  I've pushed this series now.

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH V2 13/13] libxl: use job functions in libxlDomainSetSchedulerParametersFlags

[Jim Fehlig]

Modify operation that needs to wait in the queue of modify jobs.

Signed-off-by: Jim Fehlig jfeh...@suse.com
---

V2: Check libxlDomainObjEndJob() return value

 src/libxl/libxl_driver.c | 16 
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 9741b3a..f7ca91c 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -4057,6 +4057,7 @@ libxlDomainSetSchedulerParametersFlags(virDomainPtr dom,
int nparams,
unsigned int flags)
 {
+libxlDriverPrivatePtr driver = dom-conn-privateData;
 libxlDomainObjPrivatePtr priv;
 virDomainObjPtr vm;
 libxl_domain_sched_params sc_info;
@@ -4079,9 +4080,12 @@ libxlDomainSetSchedulerParametersFlags(virDomainPtr dom,
 if (virDomainSetSchedulerParametersFlagsEnsureACL(dom-conn, vm-def, 
flags)  0)
 goto cleanup;
 
+if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY)  0)
+goto cleanup;
+
 if (!virDomainObjIsActive(vm)) {
 virReportError(VIR_ERR_OPERATION_INVALID, %s, _(Domain is not 
running));
-goto cleanup;
+goto endjob;
 }
 
 priv = vm-privateData;
@@ -4091,14 +4095,14 @@ libxlDomainSetSchedulerParametersFlags(virDomainPtr dom,
 if (sched_id != LIBXL_SCHEDULER_CREDIT) {
 virReportError(VIR_ERR_INTERNAL_ERROR, %s,
_(Only 'credit' scheduler is supported));
-goto cleanup;
+goto endjob;
 }
 
 if (libxl_domain_sched_params_get(priv-ctx, dom-id, sc_info) != 0) {
 virReportError(VIR_ERR_INTERNAL_ERROR,
_(Failed to get scheduler parameters for domain '%d'
   with libxenlight), dom-id);
-goto cleanup;
+goto endjob;
 }
 
 for (i = 0; i  nparams; ++i) {
@@ -4114,11 +4118,15 @@ libxlDomainSetSchedulerParametersFlags(virDomainPtr dom,
 virReportError(VIR_ERR_INTERNAL_ERROR,
_(Failed to set scheduler parameters for domain '%d'
   with libxenlight), dom-id);
-goto cleanup;
+goto endjob;
 }
 
 ret = 0;
 
+endjob:
+if (!libxlDomainObjEndJob(driver, vm))
+vm = NULL;
+
 cleanup:
 if (vm)
 virObjectUnlock(vm);
-- 
1.8.1.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list