Re: [libvirt] [PATCH v2] doc: Correct the default werror policy

[Martin Kletzander]

On Thu, Feb 23, 2017 at 12:30:02PM +0100, Philipp Hahn wrote:

The documentation is plain wrong about the default write_error policy,
as its only implemented by QEMU (src/vz/vz_utils.c is the only other
case, which simply explodes, is anything except other then
VIR_DOMAIN_DISK_ERROR_POLICY_DEFAULT is used).

And QEMUs default is VIR_DOMAIN_DISK_ERROR_POLICY_ENOSPACE.

Signed-off-by: Philipp Hahn 
---
docs/formatdomain.html.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
---
Osier Yang proposed v1 on 2011-10-24, which never got applied due to
discussions of "enospace" vs. "enospc".

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 02ce792..3e1a193 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -2745,7 +2745,8 @@
how the hypervisor will behave on a disk read or write
error, possible values are "stop", "report", "ignore", and
"enospace".Since 0.8.0, "report" since
-0.9.7 The default setting of error_policy is "report".
+0.9.7 The default is left to the discretion of the
+hypervisor: QEMU defaults to "enospace".


Did really all the versions do that?  I'm not sure.  Anyway, I don't
really think we should guarantee something that we have no power over,
especially since they can change the default and nobody will fix it in
our docs.  Only defaults that QEMU *driver* selects shoud be mentioned
in here (as that will also be visible in the XML), but when talking
about hypervisor defaults, I would just leave it to "hypervisor
default".


There is also an
optional rerror_policy that controls behavior
for read errors only. Since
@@ -2755,8 +2756,7 @@
read errors. Also note that "enospace" is not a valid
policy for read errors, so if error_policy is
set to "enospace" and no rerror_policy is
-given, the read error policy will be left at its default,
-which is "report".
+given, the read error policy will be left at its default.
  
  
The optional io attribute controls specific
--
2.1.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2] doc: Correct the default werror policy

[Philipp Hahn]

The documentation is plain wrong about the default write_error policy,
as its only implemented by QEMU (src/vz/vz_utils.c is the only other
case, which simply explodes, is anything except other then
VIR_DOMAIN_DISK_ERROR_POLICY_DEFAULT is used).

And QEMUs default is VIR_DOMAIN_DISK_ERROR_POLICY_ENOSPACE.

Signed-off-by: Philipp Hahn 
---
 docs/formatdomain.html.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
Osier Yang proposed v1 on 2011-10-24, which never got applied due to
discussions of "enospace" vs. "enospc".

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 02ce792..3e1a193 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -2745,7 +2745,8 @@
 how the hypervisor will behave on a disk read or write
 error, possible values are "stop", "report", "ignore", and
 "enospace".Since 0.8.0, "report" since
-0.9.7 The default setting of error_policy is "report".
+0.9.7 The default is left to the discretion of the
+hypervisor: QEMU defaults to "enospace".
 There is also an
 optional rerror_policy that controls behavior
 for read errors only. Since
@@ -2755,8 +2756,7 @@
 read errors. Also note that "enospace" is not a valid
 policy for read errors, so if error_policy is
 set to "enospace" and no rerror_policy is
-given, the read error policy will be left at its default,
-which is "report".
+given, the read error policy will be left at its default.
   
   
 The optional io attribute controls specific
-- 
2.1.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list