Re: [libvirt] [PATCH v2 0/3] Introduce hot plug support for mediated devices

2018-03-28 Thread Erik Skultety 
On Wed, Mar 28, 2018 at 03:13:02PM +0200, Peter Krempa wrote:
> On Wed, Mar 28, 2018 at 15:02:33 +0200, Erik Skultety wrote:
> > Libvirt shouldn't forbid the operation as unsupported. In fact, from VFIO 
> > point
> > of view, mdevs have supported hot plug since the beginning. Then it's up to 
> > the
> > 3rd party vendor driver whether it can cope with this feature reliably or 
> > not.
> >
> > Since v1 [1]:
> > - dropped the original patch 1 as that adjustment can be done in a bigger 
> > scale
> > across multiple modules as part of a 'bite-sized' task
> > - reworded commit message for patches 2 and 3
> > - fixed the error path in patch 1 where I mistakenly tried to re-attach all 
> > host
> > devices for a domain if the hotplug of an mdev failed
>
> ACK series

Thanks, I'll merge this once 4.2 is out.
Erik


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/3] Introduce hot plug support for mediated devices

2018-03-28 Thread Peter Krempa 
On Wed, Mar 28, 2018 at 15:02:33 +0200, Erik Skultety wrote:
> Libvirt shouldn't forbid the operation as unsupported. In fact, from VFIO 
> point
> of view, mdevs have supported hot plug since the beginning. Then it's up to 
> the
> 3rd party vendor driver whether it can cope with this feature reliably or not.
> 
> Since v1 [1]:
> - dropped the original patch 1 as that adjustment can be done in a bigger 
> scale
> across multiple modules as part of a 'bite-sized' task
> - reworded commit message for patches 2 and 3
> - fixed the error path in patch 1 where I mistakenly tried to re-attach all 
> host
> devices for a domain if the hotplug of an mdev failed

ACK series


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 0/3] Introduce hot plug support for mediated devices

2018-03-28 Thread Erik Skultety 
Libvirt shouldn't forbid the operation as unsupported. In fact, from VFIO point
of view, mdevs have supported hot plug since the beginning. Then it's up to the
3rd party vendor driver whether it can cope with this feature reliably or not.

Since v1 [1]:
- dropped the original patch 1 as that adjustment can be done in a bigger scale
across multiple modules as part of a 'bite-sized' task
- reworded commit message for patches 2 and 3
- fixed the error path in patch 1 where I mistakenly tried to re-attach all host
devices for a domain if the hotplug of an mdev failed

[1] https://www.redhat.com/archives/libvir-list/2018-March/msg01631.html

Erik Skultety (3):
  qemu: hotplug: Introduce hot plug support for mediated devices
  qemu: hotplug: Introduce hot unplug for mediated devices
  news: Update release news with mediated devices hot {plug,unplug}

 docs/news.xml   |  10 
 src/qemu/qemu_hotplug.c | 133 
 2 files changed, 143 insertions(+)

--
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list