Re: [libvirt] [PATCH v2 01/25] qemu: domain: Export qemuDomainGetImageIds

2019-12-09 Thread Ján Tomko

On Tue, Dec 03, 2019 at 06:17:23PM +0100, Peter Krempa wrote:

Signed-off-by: Peter Krempa 
---
src/qemu/qemu_domain.c | 2 +-
src/qemu/qemu_domain.h | 7 +++
2 files changed, 8 insertions(+), 1 deletion(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 01/25] qemu: domain: Export qemuDomainGetImageIds

2019-12-04 Thread Daniel P . Berrangé
On Tue, Dec 03, 2019 at 06:17:23PM +0100, Peter Krempa wrote:
> Signed-off-by: Peter Krempa 
> ---
>  src/qemu/qemu_domain.c | 2 +-
>  src/qemu/qemu_domain.h | 7 +++
>  2 files changed, 8 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé 


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 01/25] qemu: domain: Export qemuDomainGetImageIds

2019-12-03 Thread Eric Blake

On 12/3/19 11:17 AM, Peter Krempa wrote:

Signed-off-by: Peter Krempa 
---
  src/qemu/qemu_domain.c | 2 +-
  src/qemu/qemu_domain.h | 7 +++
  2 files changed, 8 insertions(+), 1 deletion(-)



Reviewed-by: Eric Blake 

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list



[libvirt] [PATCH v2 01/25] qemu: domain: Export qemuDomainGetImageIds

2019-12-03 Thread Peter Krempa
Signed-off-by: Peter Krempa 
---
 src/qemu/qemu_domain.c | 2 +-
 src/qemu/qemu_domain.h | 7 +++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 470d342afc..8d2923300d 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -10240,7 +10240,7 @@ qemuDomainCleanupRun(virQEMUDriverPtr driver,
 priv->ncleanupCallbacks_max = 0;
 }

-static void
+void
 qemuDomainGetImageIds(virQEMUDriverConfigPtr cfg,
   virDomainObjPtr vm,
   virStorageSourcePtr src,
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index f626d3a54c..608546a27c 100644
--- a/src/qemu/qemu_domain.h
+++ b/src/qemu/qemu_domain.h
@@ -840,6 +840,13 @@ bool qemuDomainDiskChangeSupported(virDomainDiskDefPtr 
disk,
 const char *qemuDomainDiskNodeFormatLookup(virDomainObjPtr vm,
const char *disk);

+void qemuDomainGetImageIds(virQEMUDriverConfigPtr cfg,
+   virDomainObjPtr vm,
+   virStorageSourcePtr src,
+   virStorageSourcePtr parentSrc,
+   uid_t *uid,
+   gid_t *gid);
+
 int qemuDomainStorageFileInit(virQEMUDriverPtr driver,
   virDomainObjPtr vm,
   virStorageSourcePtr src,
-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list