Re: [libvirt] [PATCH v2 02/11] s390-cpu: Remove nodeData and decode

[Jiri Denemark]

On Fri, Dec 09, 2016 at 14:38:31 -0500, Jason J. Herne wrote:
> On s390 , the host's features are heavily influenced by not only the host
> hardware but also by hardware microcode level, host OS version, qemu
> version and kvm version. In this environment it does not make sense to
> attempt to report exact host details.
> 
> Signed-off-by: Jason J. Herne 
> ---
>  src/cpu/cpu_s390.c | 36 ++--
>  1 file changed, 2 insertions(+), 34 deletions(-)
...

ACK

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 02/11] s390-cpu: Remove nodeData and decode

[Jason J. Herne]

On s390 , the host's features are heavily influenced by not only the host
hardware but also by hardware microcode level, host OS version, qemu
version and kvm version. In this environment it does not make sense to
attempt to report exact host details.

Signed-off-by: Jason J. Herne 
---
 src/cpu/cpu_s390.c | 36 ++--
 1 file changed, 2 insertions(+), 34 deletions(-)

diff --git a/src/cpu/cpu_s390.c b/src/cpu/cpu_s390.c
index 3efc948..68cd22f 100644
--- a/src/cpu/cpu_s390.c
+++ b/src/cpu/cpu_s390.c
@@ -33,38 +33,6 @@
 
 static const virArch archs[] = { VIR_ARCH_S390, VIR_ARCH_S390X };
 
-static virCPUDataPtr
-s390NodeData(virArch arch)
-{
-virCPUDataPtr data;
-
-if (VIR_ALLOC(data) < 0)
-return NULL;
-
-data->arch = arch;
-
-return data;
-}
-
-
-static int
-s390Decode(virCPUDefPtr cpu,
-   const virCPUData *data ATTRIBUTE_UNUSED,
-   const char **models ATTRIBUTE_UNUSED,
-   unsigned int nmodels ATTRIBUTE_UNUSED,
-   const char *preferred ATTRIBUTE_UNUSED,
-   unsigned int flags)
-{
-
-virCheckFlags(VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES, -1);
-
-if (cpu->model == NULL &&
-VIR_STRDUP(cpu->model, "host") < 0)
-return -1;
-
-return 0;
-}
-
 static void
 s390DataFree(virCPUDataPtr data)
 {
@@ -145,10 +113,10 @@ struct cpuArchDriver cpuDriverS390 = {
 .arch = archs,
 .narch = ARRAY_CARDINALITY(archs),
 .compare= virCPUs390Compare,
-.decode = s390Decode,
+.decode = NULL,
 .encode = NULL,
 .free   = s390DataFree,
-.nodeData   = s390NodeData,
+.nodeData   = NULL,
 .baseline   = NULL,
 .update = virCPUs390Update,
 };
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list