Re: [libvirt] [PATCH v2 02/12] remote: Implement virDomainDetachDeviceAlias

[Ján Tomko]

On Thu, May 24, 2018 at 01:13:29PM +0200, Michal Privoznik wrote:

Signed-off-by: Michal Privoznik 
---
src/remote/remote_driver.c   |  1 +
src/remote/remote_protocol.x | 16 +++-
src/remote_protocol-structs  |  6 ++
3 files changed, 22 insertions(+), 1 deletion(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v2 02/12] remote: Implement virDomainDetachDeviceAlias

[Michal Privoznik]

Signed-off-by: Michal Privoznik 
---
 src/remote/remote_driver.c   |  1 +
 src/remote/remote_protocol.x | 16 +++-
 src/remote_protocol-structs  |  6 ++
 3 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 95437b4365..8695046b71 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -8308,6 +8308,7 @@ static virHypervisorDriver hypervisor_driver = {
 .domainDetachDevice = remoteDomainDetachDevice, /* 0.3.0 */
 .domainDetachDeviceFlags = remoteDomainDetachDeviceFlags, /* 0.7.7 */
 .domainUpdateDeviceFlags = remoteDomainUpdateDeviceFlags, /* 0.8.0 */
+.domainDetachDeviceAlias = remoteDomainDetachDeviceAlias, /* 4.4.0 */
 .domainGetAutostart = remoteDomainGetAutostart, /* 0.3.0 */
 .domainSetAutostart = remoteDomainSetAutostart, /* 0.3.0 */
 .domainGetSchedulerType = remoteDomainGetSchedulerType, /* 0.3.0 */
diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
index 296a087181..b23c93514a 100644
--- a/src/remote/remote_protocol.x
+++ b/src/remote/remote_protocol.x
@@ -1284,6 +1284,12 @@ struct remote_domain_update_device_flags_args {
 unsigned int flags;
 };
 
+struct remote_domain_detach_device_alias_args {
+remote_nonnull_domain dom;
+remote_nonnull_string alias;
+unsigned int flags;
+};
+
 struct remote_domain_get_autostart_args {
 remote_nonnull_domain dom;
 };
@@ -6135,5 +6141,13 @@ enum remote_procedure {
  * @priority: high
  * @acl: storage_pool:getattr
  */
-REMOTE_PROC_STORAGE_POOL_LOOKUP_BY_TARGET_PATH = 391
+REMOTE_PROC_STORAGE_POOL_LOOKUP_BY_TARGET_PATH = 391,
+
+/**
+ * @generate: both
+ * @acl: domain:write
+ * @acl: domain:save:!VIR_DOMAIN_AFFECT_CONFIG|VIR_DOMAIN_AFFECT_LIVE
+ * @acl: domain:save:VIR_DOMAIN_AFFECT_CONFIG
+ */
+REMOTE_PROC_DOMAIN_DETACH_DEVICE_ALIAS = 392
 };
diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
index fe163db73f..1b4fbc5d4b 100644
--- a/src/remote_protocol-structs
+++ b/src/remote_protocol-structs
@@ -915,6 +915,11 @@ struct remote_domain_update_device_flags_args {
 remote_nonnull_string  xml;
 u_int  flags;
 };
+struct remote_domain_detach_device_alias_args {
+remote_nonnull_domain  dom;
+remote_nonnull_string  alias;
+u_int  flags;
+};
 struct remote_domain_get_autostart_args {
 remote_nonnull_domain  dom;
 };
@@ -3269,4 +3274,5 @@ enum remote_procedure {
 REMOTE_PROC_DOMAIN_MANAGED_SAVE_DEFINE_XML = 389,
 REMOTE_PROC_DOMAIN_SET_LIFECYCLE_ACTION = 390,
 REMOTE_PROC_STORAGE_POOL_LOOKUP_BY_TARGET_PATH = 391,
+REMOTE_PROC_DOMAIN_DETACH_DEVICE_ALIAS = 392,
 };
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list