Re: [libvirt] [PATCH v2 09/10] qemu: capabilities: Always assume QEMU_CAPS_ADD_FD

2018-08-23 Thread John Ferlan



On 08/15/2018 05:18 AM, Peter Krempa wrote:
> The capability was usable since qemu 1.3 so we can remove all the
> detection code.
> 
> Signed-off-by: Peter Krempa 
> ---
>  src/qemu/qemu_capabilities.c   | 17 
>  src/qemu/qemu_capabilities.h   |  2 +-
>  src/qemu/qemu_command.c| 32 
> ++
>  .../qemucapabilitiesdata/caps_1.5.3.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_1.6.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_1.7.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.1.1.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml   |  3 +-
>  .../caps_2.10.0.aarch64.replies| 17 
>  tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml |  3 +-
>  .../qemucapabilitiesdata/caps_2.10.0.ppc64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.10.0.s390x.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml   |  3 +-
>  .../caps_2.10.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml  |  3 +-
>  .../qemucapabilitiesdata/caps_2.11.0.s390x.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml   |  3 +-
>  .../caps_2.11.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml  |  3 +-
>  .../caps_2.12.0.aarch64.replies| 17 
>  tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml |  3 +-
>  .../qemucapabilitiesdata/caps_2.12.0.ppc64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.12.0.s390x.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml   |  3 +-
>  .../caps_2.12.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml  |  3 +-
>  .../qemucapabilitiesdata/caps_2.4.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml   |  3 +-
>  .../caps_2.6.0.aarch64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml  |  3 +-
>  .../qemucapabilitiesdata/caps_2.6.0.ppc64.replies  | 17 
>  tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml|  3 +-
>  .../qemucapabilitiesdata/caps_2.6.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.7.0.s390x.replies  | 17 
>  tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml|  3 +-
>  .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.8.0.s390x.replies  | 17 
>  tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml|  3 +-
>  .../qemucapabilitiesdata/caps_2.8.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_2.9.0.ppc64.replies  | 17 
>  tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml|  3 +-
>  .../qemucapabilitiesdata/caps_2.9.0.s390x.replies  | 17 
>  tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml|  3 +-
>  .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml   |  3 +-
>  .../qemucapabilitiesdata/caps_3.0.0.ppc64.replies  | 17 
>  tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml|  3 +-
>  .../qemucapabilitiesdata/caps_3.0.0.x86_64.replies | 17 
>  tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml   |  3 +-
>  tests/qemuxml2argvtest.c   |  2 --
>  60 files changed, 43 insertions(+), 570 deletions(-)
> 

Reviewed-by: John Ferlan 

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH v2 09/10] qemu: capabilities: Always assume QEMU_CAPS_ADD_FD

2018-08-15 Thread Peter Krempa
The capability was usable since qemu 1.3 so we can remove all the
detection code.

Signed-off-by: Peter Krempa 
---
 src/qemu/qemu_capabilities.c   | 17 
 src/qemu/qemu_capabilities.h   |  2 +-
 src/qemu/qemu_command.c| 32 ++
 .../qemucapabilitiesdata/caps_1.5.3.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml   |  3 +-
 .../qemucapabilitiesdata/caps_1.6.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml   |  3 +-
 .../qemucapabilitiesdata/caps_1.7.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml   |  3 +-
 .../qemucapabilitiesdata/caps_2.1.1.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml   |  3 +-
 .../caps_2.10.0.aarch64.replies| 17 
 tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml |  3 +-
 .../qemucapabilitiesdata/caps_2.10.0.ppc64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml   |  3 +-
 .../qemucapabilitiesdata/caps_2.10.0.s390x.replies | 17 
 tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml   |  3 +-
 .../caps_2.10.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml  |  3 +-
 .../qemucapabilitiesdata/caps_2.11.0.s390x.replies | 17 
 tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml   |  3 +-
 .../caps_2.11.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml  |  3 +-
 .../caps_2.12.0.aarch64.replies| 17 
 tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml |  3 +-
 .../qemucapabilitiesdata/caps_2.12.0.ppc64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml   |  3 +-
 .../qemucapabilitiesdata/caps_2.12.0.s390x.replies | 17 
 tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml   |  3 +-
 .../caps_2.12.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml  |  3 +-
 .../qemucapabilitiesdata/caps_2.4.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml   |  3 +-
 .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml   |  3 +-
 .../caps_2.6.0.aarch64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml  |  3 +-
 .../qemucapabilitiesdata/caps_2.6.0.ppc64.replies  | 17 
 tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml|  3 +-
 .../qemucapabilitiesdata/caps_2.6.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml   |  3 +-
 .../qemucapabilitiesdata/caps_2.7.0.s390x.replies  | 17 
 tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml|  3 +-
 .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml   |  3 +-
 .../qemucapabilitiesdata/caps_2.8.0.s390x.replies  | 17 
 tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml|  3 +-
 .../qemucapabilitiesdata/caps_2.8.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml   |  3 +-
 .../qemucapabilitiesdata/caps_2.9.0.ppc64.replies  | 17 
 tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml|  3 +-
 .../qemucapabilitiesdata/caps_2.9.0.s390x.replies  | 17 
 tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml|  3 +-
 .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml   |  3 +-
 .../qemucapabilitiesdata/caps_3.0.0.ppc64.replies  | 17 
 tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml|  3 +-
 .../qemucapabilitiesdata/caps_3.0.0.x86_64.replies | 17 
 tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml   |  3 +-
 tests/qemuxml2argvtest.c   |  2 --
 60 files changed, 43 insertions(+), 570 deletions(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 755a666ab1..4b81c331b0 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -1008,7 +1008,6 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = {
 { "query-vnc", QEMU_CAPS_VNC },
 { "drive-mirror", QEMU_CAPS_DRIVE_MIRROR },
 { "blockdev-snapshot-sync", QEMU_CAPS_DISK_SNAPSHOT },
-{ "add-fd", QEMU_CAPS_ADD_FD },
 { "nbd-server-start", QEMU_CAPS_NBD_SERVER },
 { "change-backing-file", QEMU_CAPS_CHANGE_BACKING_FILE },
 { "rtc-reset-reinjection", QEMU_CAPS_RTC_RESET_REINJECTION },
@@ -2123,22 +2122,6 @@ virQEMUCapsProbeQMPCommands(virQEMUCapsPtr qemuCaps,
   ncommands, commands);
 virStringListFreeCount(commands, ncommands);

-/* QMP add-fd was introduced in 1.2, but did not support
- * management control of set numbering, and