Re: [libvirt] [PATCH v2 18/25] conf: backup: Add fields for tracking stats of completed sub-jobs
On Tue, Dec 03, 2019 at 06:17:40PM +0100, Peter Krempa wrote: We need a place to store stats of completed sub-jobs so that we can later report accurate stats. Signed-off-by: Peter Krempa --- src/conf/backup_conf.h | 7 +++ 1 file changed, 7 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 18/25] conf: backup: Add fields for tracking stats of completed sub-jobs
On 12/3/19 11:17 AM, Peter Krempa wrote:
We need a place to store stats of completed sub-jobs so that we can
later report accurate stats.
Signed-off-by: Peter Krempa
---
src/conf/backup_conf.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/conf/backup_conf.h b/src/conf/backup_conf.h
index c970e01920..5dfc42e297 100644
--- a/src/conf/backup_conf.h
+++ b/src/conf/backup_conf.h
@@ -70,6 +70,13 @@ struct _virDomainBackupDef {
size_t ndisks; /* should not exceed dom->ndisks */
virDomainBackupDiskDef *disks;
+
+/* internal data */
+/* statistic totals for completed diks */
disks
With typo fix,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 18/25] conf: backup: Add fields for tracking stats of completed sub-jobs
On Tue, Dec 03, 2019 at 06:17:40PM +0100, Peter Krempa wrote: > We need a place to store stats of completed sub-jobs so that we can > later report accurate stats. Its kind of gross using the public struct for internal only data but I guess we can fix that any time we want to later. > > Signed-off-by: Peter Krempa > --- > src/conf/backup_conf.h | 7 +++ > 1 file changed, 7 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH v2 18/25] conf: backup: Add fields for tracking stats of completed sub-jobs
We need a place to store stats of completed sub-jobs so that we can
later report accurate stats.
Signed-off-by: Peter Krempa
---
src/conf/backup_conf.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/conf/backup_conf.h b/src/conf/backup_conf.h
index c970e01920..5dfc42e297 100644
--- a/src/conf/backup_conf.h
+++ b/src/conf/backup_conf.h
@@ -70,6 +70,13 @@ struct _virDomainBackupDef {
size_t ndisks; /* should not exceed dom->ndisks */
virDomainBackupDiskDef *disks;
+
+/* internal data */
+/* statistic totals for completed diks */
+unsigned long long push_transferred;
+unsigned long long push_total;
+unsigned long long pull_tmp_used;
+unsigned long long pull_tmp_total;
};
typedef enum {
--
2.23.0
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
