[libvirt] [PATCH v2 3/3] tests: Add tests for dump-core option

2012-09-20 Thread Martin Kletzander
---
 tests/qemuargv2xmltest.c   |  2 ++
 .../qemuxml2argv-machine-core-off.args |  5 +
 .../qemuxml2argv-machine-core-off.xml  | 26 ++
 .../qemuxml2argv-machine-core-on.args  |  5 +
 .../qemuxml2argv-machine-core-on.xml   | 26 ++
 tests/qemuxml2argvtest.c   |  3 +++
 tests/qemuxml2xmltest.c|  2 ++
 7 files changed, 69 insertions(+)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.xml

diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c
index c4c2cd9..5e51d32 100644
--- a/tests/qemuargv2xmltest.c
+++ b/tests/qemuargv2xmltest.c
@@ -142,6 +142,8 @@ mymain(void)

 /* Can't roundtrip vcpu  cpuset attribute */
 /*DO_TEST(minimal, QEMU_CAPS_NAME);*/
+DO_TEST(machine-core-on);
+DO_TEST(machine-core-off);
 DO_TEST(boot-cdrom);
 DO_TEST(boot-network);
 DO_TEST(boot-floppy);
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.args 
b/tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.args
new file mode 100644
index 000..67b134f
--- /dev/null
+++ b/tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.args
@@ -0,0 +1,5 @@
+LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu \
+-S -machine pc,dump-guest-core=off -m 214 -smp 1 -nographic \
+-monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c \
+-hda /dev/HostVG/QEMUGuest1 -net none -serial \
+none -parallel none -usb
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.xml 
b/tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.xml
new file mode 100644
index 000..3e5b300
--- /dev/null
+++ b/tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.xml
@@ -0,0 +1,26 @@
+domain type='qemu'
+  nameQEMUGuest1/name
+  uuidc7a5fdbd-edaf-9455-926a-d65c16db1809/uuid
+  memory dump-core='off' unit='KiB'219100/memory
+  currentMemory unit='KiB'219100/currentMemory
+  vcpu placement='static'1/vcpu
+  os
+type arch='i686' machine='pc'hvm/type
+boot dev='hd'/
+  /os
+  clock offset='utc'/
+  on_poweroffdestroy/on_poweroff
+  on_rebootrestart/on_reboot
+  on_crashdestroy/on_crash
+  devices
+emulator/usr/bin/qemu/emulator
+disk type='block' device='disk'
+  source dev='/dev/HostVG/QEMUGuest1'/
+  target dev='hda' bus='ide'/
+  address type='drive' controller='0' bus='0' target='0' unit='0'/
+/disk
+controller type='usb' index='0'/
+controller type='ide' index='0'/
+memballoon model='virtio'/
+  /devices
+/domain
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.args 
b/tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.args
new file mode 100644
index 000..189f2fb
--- /dev/null
+++ b/tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.args
@@ -0,0 +1,5 @@
+LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu \
+-S -machine pc,dump-guest-core=on -m 214 -smp 1 -nographic \
+-monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c \
+-hda /dev/HostVG/QEMUGuest1 -net none -serial \
+none -parallel none -usb
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.xml 
b/tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.xml
new file mode 100644
index 000..bc22a5d
--- /dev/null
+++ b/tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.xml
@@ -0,0 +1,26 @@
+domain type='qemu'
+  nameQEMUGuest1/name
+  uuidc7a5fdbd-edaf-9455-926a-d65c16db1809/uuid
+  memory dump-core='on' unit='KiB'219100/memory
+  currentMemory unit='KiB'219100/currentMemory
+  vcpu placement='static'1/vcpu
+  os
+type arch='i686' machine='pc'hvm/type
+boot dev='hd'/
+  /os
+  clock offset='utc'/
+  on_poweroffdestroy/on_poweroff
+  on_rebootrestart/on_reboot
+  on_crashdestroy/on_crash
+  devices
+emulator/usr/bin/qemu/emulator
+disk type='block' device='disk'
+  source dev='/dev/HostVG/QEMUGuest1'/
+  target dev='hda' bus='ide'/
+  address type='drive' controller='0' bus='0' target='0' unit='0'/
+/disk
+controller type='usb' index='0'/
+controller type='ide' index='0'/
+memballoon model='virtio'/
+  /devices
+/domain
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 629d767..90dad17 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -347,6 +347,9 @@ mymain(void)
 DO_TEST(minimal-s390, QEMU_CAPS_NAME);
 DO_TEST(machine-aliases1, NONE);
 DO_TEST(machine-aliases2, QEMU_CAPS_KVM);
+DO_TEST(machine-core-on, QEMU_CAPS_DUMP_GUEST_CORE);
+DO_TEST(machine-core-off, QEMU_CAPS_DUMP_GUEST_CORE);
+DO_TEST_FAILURE(machine-core-on, NONE);
 DO_TEST(boot-cdrom, NONE);
 DO_TEST(boot-network, NONE);
 

Re: [libvirt] [PATCH v2 3/3] tests: Add tests for dump-core option

2012-09-20 Thread Michal Privoznik
On 20.09.2012 10:58, Martin Kletzander wrote:
 ---
  tests/qemuargv2xmltest.c   |  2 ++
  .../qemuxml2argv-machine-core-off.args |  5 +
  .../qemuxml2argv-machine-core-off.xml  | 26 
 ++
  .../qemuxml2argv-machine-core-on.args  |  5 +
  .../qemuxml2argv-machine-core-on.xml   | 26 
 ++
  tests/qemuxml2argvtest.c   |  3 +++
  tests/qemuxml2xmltest.c|  2 ++
  7 files changed, 69 insertions(+)
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.args
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.xml
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.args
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.xml
 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH v2 3/3] tests: Add tests for dump-core option

2012-09-20 Thread Martin Kletzander
On 09/20/2012 02:54 PM, Michal Privoznik wrote:
 On 20.09.2012 10:58, Martin Kletzander wrote:
 ---
  tests/qemuargv2xmltest.c   |  2 ++
  .../qemuxml2argv-machine-core-off.args |  5 +
  .../qemuxml2argv-machine-core-off.xml  | 26 
 ++
  .../qemuxml2argv-machine-core-on.args  |  5 +
  .../qemuxml2argv-machine-core-on.xml   | 26 
 ++
  tests/qemuxml2argvtest.c   |  3 +++
  tests/qemuxml2xmltest.c|  2 ++
  7 files changed, 69 insertions(+)
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.args
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.xml
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.args
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.xml

 
 ACK
 
 Michal
 

Thanks, pushed.

Martin

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list