Re: [libvirt] [PATCH v3 17/18] qemu: Const-correct snapshot directory name

2019-03-07 Thread John Ferlan 



On 3/4/19 10:34 PM, Eric Blake wrote:
> qemuDomainSnapshotWriteMetadata does not modify the directory name,
> and making it const-correct aids in writing an upcoming patch.
> 
> Signed-off-by: Eric Blake 
> ---
>  src/qemu/qemu_domain.h | 2 +-
>  src/qemu/qemu_domain.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: John Ferlan 

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v3 17/18] qemu: Const-correct snapshot directory name

2019-03-04 Thread Eric Blake 
qemuDomainSnapshotWriteMetadata does not modify the directory name,
and making it const-correct aids in writing an upcoming patch.

Signed-off-by: Eric Blake 
---
 src/qemu/qemu_domain.h | 2 +-
 src/qemu/qemu_domain.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index 7c6b50184c..37c9813ec5 100644
--- a/src/qemu/qemu_domain.h
+++ b/src/qemu/qemu_domain.h
@@ -683,7 +683,7 @@ int qemuDomainSnapshotWriteMetadata(virDomainObjPtr vm,
 virDomainSnapshotObjPtr snapshot,
 virCapsPtr caps,
 virDomainXMLOptionPtr xmlopt,
-char *snapshotDir);
+const char *snapshotDir);

 int qemuDomainSnapshotForEachQcow2(virQEMUDriverPtr driver,
virDomainObjPtr vm,
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 3ac79fa50b..6f8e03ba36 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -8399,7 +8399,7 @@ qemuDomainSnapshotWriteMetadata(virDomainObjPtr vm,
 virDomainSnapshotObjPtr snapshot,
 virCapsPtr caps,
 virDomainXMLOptionPtr xmlopt,
-char *snapshotDir)
+const char *snapshotDir)
 {
 char *newxml = NULL;
 int ret = -1;
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list