Re: [libvirt] [PATCH v3 2/5] conf: change the way how Hyper-V features are printed out

2019-08-06 Thread Ján Tomko 

On Tue, Aug 06, 2019 at 07:52:33AM +0200, Vitaly Kuznetsov wrote:

Current code doesn't allow us to add sub-features as we always print the
closing '/>'. As a preparatory change to implementing 'direct' sub-feature
for 'stimer' feature switch to printing closing tag individually.

No functional change.

Signed-off-by: Vitaly Kuznetsov 
---
src/conf/domain_conf.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH v3 2/5] conf: change the way how Hyper-V features are printed out

2019-08-05 Thread Vitaly Kuznetsov 
Current code doesn't allow us to add sub-features as we always print the
closing '/>'. As a preparatory change to implementing 'direct' sub-feature
for 'stimer' feature switch to printing closing tag individually.

No functional change.

Signed-off-by: Vitaly Kuznetsov 
---
 src/conf/domain_conf.c | 15 +--
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 5cd9939031..f75ee03e9b 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -28078,19 +28078,24 @@ virDomainDefFormatFeatures(virBufferPtr buf,
 case VIR_DOMAIN_HYPERV_TLBFLUSH:
 case VIR_DOMAIN_HYPERV_IPI:
 case VIR_DOMAIN_HYPERV_EVMCS:
+virBufferAddLit(, "/>\n");
 break;
 
 case VIR_DOMAIN_HYPERV_SPINLOCKS:
-if (def->hyperv_features[j] != VIR_TRISTATE_SWITCH_ON)
+if (def->hyperv_features[j] != VIR_TRISTATE_SWITCH_ON) {
+virBufferAddLit(, "/>\n");
 break;
-virBufferAsprintf(, " retries='%d'",
+}
+virBufferAsprintf(, " retries='%d'/>\n",
   def->hyperv_spinlocks);
 break;
 
 case VIR_DOMAIN_HYPERV_VENDOR_ID:
-if (def->hyperv_features[j] != VIR_TRISTATE_SWITCH_ON)
+if (def->hyperv_features[j] != VIR_TRISTATE_SWITCH_ON) {
+virBufferAddLit(, "/>\n");
 break;
-virBufferEscapeString(, " value='%s'",
+}
+virBufferEscapeString(, " value='%s'/>\n",
   def->hyperv_vendor_id);
 break;
 
@@ -28098,8 +28103,6 @@ virDomainDefFormatFeatures(virBufferPtr buf,
 case VIR_DOMAIN_HYPERV_LAST:
 break;
 }
-
-virBufferAddLit(, "/>\n");
 }
 virBufferAdjustIndent(, -2);
 virBufferAddLit(, "\n");
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list