Re: [libvirt] [PATCH v5 07/15] qemu_monitor: implement query-cpu-model-baseline

2019-10-02 Thread Jiri Denemark
On Thu, Sep 19, 2019 at 16:24:58 -0400, Collin Walling wrote:
> Interfaces with QEMU to baseline CPU models. The command takes two
> CPU models, A and B, that are given a model name and an optional list
> of CPU features. Through the query-cpu-model-baseline command issued
> via QMP, a result is produced that contains a new baselined CPU model
> that is guaranteed to run on both A and B.
> 
> Signed-off-by: Collin Walling 
> Reviewed-by: Daniel Henrique Barboza 
> ---
>  src/qemu/qemu_monitor.c  | 14 ++
>  src/qemu/qemu_monitor.h  |  5 +
>  src/qemu/qemu_monitor_json.c | 42 ++
>  src/qemu/qemu_monitor_json.h |  6 ++
>  4 files changed, 67 insertions(+)

Reviewed-by: Jiri Denemark 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


[libvirt] [PATCH v5 07/15] qemu_monitor: implement query-cpu-model-baseline

2019-09-19 Thread Collin Walling
Interfaces with QEMU to baseline CPU models. The command takes two
CPU models, A and B, that are given a model name and an optional list
of CPU features. Through the query-cpu-model-baseline command issued
via QMP, a result is produced that contains a new baselined CPU model
that is guaranteed to run on both A and B.

Signed-off-by: Collin Walling 
Reviewed-by: Daniel Henrique Barboza 
---
 src/qemu/qemu_monitor.c  | 14 ++
 src/qemu/qemu_monitor.h  |  5 +
 src/qemu/qemu_monitor_json.c | 42 ++
 src/qemu/qemu_monitor_json.h |  6 ++
 4 files changed, 67 insertions(+)

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 6bda620..834eaf2 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -3731,6 +3731,20 @@ qemuMonitorGetCPUModelExpansion(qemuMonitorPtr mon,
 }
 
 
+int
+qemuMonitorGetCPUModelBaseline(qemuMonitorPtr mon,
+   virCPUDefPtr cpu_a,
+   virCPUDefPtr cpu_b,
+   qemuMonitorCPUModelInfoPtr *baseline)
+{
+VIR_DEBUG("cpu_a=%p cpu_b=%p", cpu_a, cpu_b);
+
+QEMU_CHECK_MONITOR(mon);
+
+return qemuMonitorJSONGetCPUModelBaseline(mon, cpu_a, cpu_b, baseline);
+}
+
+
 void
 qemuMonitorCPUModelInfoFree(qemuMonitorCPUModelInfoPtr model_info)
 {
diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
index c9cb3bd..8974ba8 100644
--- a/src/qemu/qemu_monitor.h
+++ b/src/qemu/qemu_monitor.h
@@ -1164,6 +1164,11 @@ int qemuMonitorGetCPUModelExpansion(qemuMonitorPtr mon,
 
 void qemuMonitorCPUModelInfoFree(qemuMonitorCPUModelInfoPtr model_info);
 
+int qemuMonitorGetCPUModelBaseline(qemuMonitorPtr mon,
+   virCPUDefPtr cpu_a,
+   virCPUDefPtr cpu_b,
+   qemuMonitorCPUModelInfoPtr *baseline);
+
 qemuMonitorCPUModelInfoPtr
 qemuMonitorCPUModelInfoCopy(const qemuMonitorCPUModelInfo *orig);
 
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 13ee323..679531d 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -5974,6 +5974,48 @@ qemuMonitorJSONGetCPUModelExpansion(qemuMonitorPtr mon,
 }
 
 
+int
+qemuMonitorJSONGetCPUModelBaseline(qemuMonitorPtr mon,
+   virCPUDefPtr cpu_a,
+   virCPUDefPtr cpu_b,
+   qemuMonitorCPUModelInfoPtr *baseline)
+{
+VIR_AUTOPTR(virJSONValue) model_a = NULL;
+VIR_AUTOPTR(virJSONValue) model_b = NULL;
+VIR_AUTOPTR(virJSONValue) cmd = NULL;
+VIR_AUTOPTR(virJSONValue) reply = NULL;
+virJSONValuePtr data;
+virJSONValuePtr cpu_model;
+virJSONValuePtr cpu_props = NULL;
+const char *cpu_name = "";
+
+if (!(model_a = qemuMonitorJSONMakeCPUModel(cpu_a, true)) ||
+!(model_b = qemuMonitorJSONMakeCPUModel(cpu_b, true)))
+return -1;
+
+if (!(cmd = qemuMonitorJSONMakeCommand("query-cpu-model-baseline",
+   "a:modela", _a,
+   "a:modelb", _b,
+   NULL)))
+return -1;
+
+if (qemuMonitorJSONCommand(mon, cmd, ) < 0)
+return -1;
+
+if (qemuMonitorJSONCheckReply(cmd, reply, VIR_JSON_TYPE_OBJECT) < 0)
+return -1;
+
+data = virJSONValueObjectGetObject(reply, "return");
+
+if (qemuMonitorJSONParseCPUModelData(data, "query-cpu-model-baseline",
+ false, _model, _props,
+ _name) < 0)
+return -1;
+
+return qemuMonitorJSONParseCPUModel(cpu_name, cpu_props, baseline);
+}
+
+
 int qemuMonitorJSONGetCommands(qemuMonitorPtr mon,
char ***commands)
 {
diff --git a/src/qemu/qemu_monitor_json.h b/src/qemu/qemu_monitor_json.h
index 682710f..77ea41b 100644
--- a/src/qemu/qemu_monitor_json.h
+++ b/src/qemu/qemu_monitor_json.h
@@ -396,6 +396,12 @@ int qemuMonitorJSONGetCPUModelExpansion(qemuMonitorPtr mon,
 qemuMonitorCPUModelInfoPtr *model_info)
 ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(6);
 
+int qemuMonitorJSONGetCPUModelBaseline(qemuMonitorPtr mon,
+   virCPUDefPtr cpu_a,
+   virCPUDefPtr cpu_b,
+   qemuMonitorCPUModelInfoPtr *baseline)
+ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4);
+
 int qemuMonitorJSONGetCommands(qemuMonitorPtr mon,
char ***commands)
 ATTRIBUTE_NONNULL(2);
-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list