Re: [libvirt] [PATCHv3 00/10] Add BlkIO and CPU/mem stat API implementations for lxc
I wrote: This patch set adds block io, memory and domain cpu statistics API slot implementations to the LXC driver, in order to get linux container monitoring and accounting a bit closer to qemu standards. Hi guys, hmm, this would be cool to get into 1.2.2 - any chance for that? ;) Some patches were ACKed already, and I've addressed the remaining review comments on 02, 04 and 07. For 05, I did not modify the qemu driver, but relaxed the docs in 06 already (there was no explicit failure mode for that case anyway, in libvirt.c). Thanks a lot, -- Thorsten signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCHv3 00/10] Add BlkIO and CPU/mem stat API implementations for lxc
On Wed, Feb 19, 2014 at 08:38:33PM +0100, Thorsten Behrens wrote: I wrote: This patch set adds block io, memory and domain cpu statistics API slot implementations to the LXC driver, in order to get linux container monitoring and accounting a bit closer to qemu standards. Hi guys, hmm, this would be cool to get into 1.2.2 - any chance for that? ;) Some patches were ACKed already, and I've addressed the remaining review comments on 02, 04 and 07. For 05, I did not modify the qemu driver, but relaxed the docs in 06 already (there was no explicit failure mode for that case anyway, in libvirt.c). I'll review the rest of this tomorrow if no one beats me to it. Getting into 1.2.2 is a reasonable target. Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCHv3 00/10] Add BlkIO and CPU/mem stat API implementations for lxc
On 03.02.2014 18:44, Thorsten Behrens wrote: This patch set adds block io, memory and domain cpu statistics API slot implementations to the LXC driver, in order to get linux container monitoring and accounting a bit closer to qemu standards. The last patch is a tad quirky (happy to hear suggestions on alternative ways), in that it widens the permissible value set at the .domainBlockStats slot: for lxc guests, it is relatively likely to have zero disk devices, since host filesystems can be used via passthrough bind mounts. Therefore, passing the zero-length string as device path, is interpreted as 'return summary stats for the entire domains's block io'. Right. We can add test for both, can't we? Anyway, I've ACKed most of the patches except a few. Can you please fix resend them? I'll do the review and (hopefully) push them too. Nice work! Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCHv3 00/10] Add BlkIO and CPU/mem stat API implementations for lxc
This patch set adds block io, memory and domain cpu statistics API slot implementations to the LXC driver, in order to get linux container monitoring and accounting a bit closer to qemu standards. The last patch is a tad quirky (happy to hear suggestions on alternative ways), in that it widens the permissible value set at the .domainBlockStats slot: for lxc guests, it is relatively likely to have zero disk devices, since host filesystems can be used via passthrough bind mounts. Therefore, passing the zero-length string as device path, is interpreted as 'return summary stats for the entire domains's block io'. v3 addresses review comments, and adds unit tests for good measure. Thorsten Behrens (10): Add util virCgroupGetBlkioIo*Serviced methods. Implement domainMemoryStats API slot for LXC driver. Make qemuGetDomainTotalCPUStats a virCgroup function. Implement domainGetCPUStats for lxc driver. Implement lxcDomainBlockStats* for lxc driver Widening API change - accept empty path for virDomainBlockStats Add unit test for virCgroupGetBlkioIo*Serviced Add unit test for virCgroupGetMemoryUsage. Fix misspelled cpuacct.usage_percpu in cgroup mock. Add unit test for virCgroupGetPercpuStats. src/libvirt.c| 8 +- src/libvirt_private.syms | 4 + src/lxc/lxc_driver.c | 297 + src/qemu/qemu_driver.c | 54 +- src/util/vircgroup.c | 382 +++ src/util/vircgroup.h | 24 +++ tests/vircgroupmock.c| 109 +++- tests/vircgrouptest.c| 234 ++ tools/virsh-domain-monitor.c | 11 +- tools/virsh.pod | 5 +- 10 files changed, 1066 insertions(+), 62 deletions(-) -- 1.8.4 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
