Re: [libvirt] [dbus PATCH] connect: fix calls to virtDBusConnectOpen

[Ján Tomko]

Even though the changes are self-explanatory, the commit message could
use some text, e.g.:

The function returns TRUE/FALSE, not 0/-1.

On Tue, Jul 24, 2018 at 09:31:28AM -0400, Anya Harter wrote:

Signed-off-by: Anya Harter 
---
src/domain.c  | 2 +-
src/interface.c   | 2 +-
src/network.c | 2 +-
src/nodedev.c | 2 +-
src/nwfilter.c| 2 +-
src/secret.c  | 2 +-
src/storagepool.c | 2 +-
src/storagevol.c  | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)



Reviewed-by: Ján Tomko 

Jano


signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [dbus PATCH] connect: fix calls to virtDBusConnectOpen

[Anya Harter]

Signed-off-by: Anya Harter 
---
 src/domain.c  | 2 +-
 src/interface.c   | 2 +-
 src/network.c | 2 +-
 src/nodedev.c | 2 +-
 src/nwfilter.c| 2 +-
 src/secret.c  | 2 +-
 src/storagepool.c | 2 +-
 src/storagevol.c  | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/domain.c b/src/domain.c
index 5c5e6da..e8b1a0e 100644
--- a/src/domain.c
+++ b/src/domain.c
@@ -152,7 +152,7 @@ virtDBusDomainGetVirDomain(virtDBusConnect *connect,
 {
 virDomainPtr domain;
 
-if (virtDBusConnectOpen(connect, error) < 0)
+if (!virtDBusConnectOpen(connect, error))
 return NULL;
 
 domain = virtDBusUtilVirDomainFromBusPath(connect->connection,
diff --git a/src/interface.c b/src/interface.c
index 191b8be..6c24885 100644
--- a/src/interface.c
+++ b/src/interface.c
@@ -10,7 +10,7 @@ virtDBusInterfaceGetVirInterface(virtDBusConnect *connect,
 {
 virInterfacePtr interface;
 
-if (virtDBusConnectOpen(connect, error) < 0)
+if (!virtDBusConnectOpen(connect, error))
 return NULL;
 
 interface = virtDBusUtilVirInterfaceFromBusPath(connect->connection,
diff --git a/src/network.c b/src/network.c
index 3957ee6..f3d5472 100644
--- a/src/network.c
+++ b/src/network.c
@@ -21,7 +21,7 @@ virtDBusNetworkGetVirNetwork(virtDBusConnect *connect,
 {
 virNetworkPtr network;
 
-if (virtDBusConnectOpen(connect, error) < 0)
+if (!virtDBusConnectOpen(connect, error))
 return NULL;
 
 network = virtDBusUtilVirNetworkFromBusPath(connect->connection,
diff --git a/src/nodedev.c b/src/nodedev.c
index aa649c6..04fe29c 100644
--- a/src/nodedev.c
+++ b/src/nodedev.c
@@ -10,7 +10,7 @@ virtDBusNodeDeviceGetVirNodeDevice(virtDBusConnect *connect,
 {
 virNodeDevicePtr dev;
 
-if (virtDBusConnectOpen(connect, error) < 0)
+if (!virtDBusConnectOpen(connect, error))
 return NULL;
 
 dev = virtDBusUtilVirNodeDeviceFromBusPath(connect->connection,
diff --git a/src/nwfilter.c b/src/nwfilter.c
index 3fc6e12..d101778 100644
--- a/src/nwfilter.c
+++ b/src/nwfilter.c
@@ -10,7 +10,7 @@ virtDBusNWFilterGetVirNWFilter(virtDBusConnect *connect,
 {
 virNWFilterPtr nwfilter;
 
-if (virtDBusConnectOpen(connect, error) < 0)
+if (!virtDBusConnectOpen(connect, error))
 return NULL;
 
 nwfilter = virtDBusUtilVirNWFilterFromBusPath(connect->connection,
diff --git a/src/secret.c b/src/secret.c
index 903cfc2..85982f1 100644
--- a/src/secret.c
+++ b/src/secret.c
@@ -10,7 +10,7 @@ virtDBusSecretGetVirSecret(virtDBusConnect *connect,
 {
 virSecretPtr secret;
 
-if (virtDBusConnectOpen(connect, error) < 0)
+if (!virtDBusConnectOpen(connect, error))
 return NULL;
 
 secret = virtDBusUtilVirSecretFromBusPath(connect->connection,
diff --git a/src/storagepool.c b/src/storagepool.c
index 6eb6f27..b4d4f93 100644
--- a/src/storagepool.c
+++ b/src/storagepool.c
@@ -10,7 +10,7 @@ virtDBusStoragePoolGetVirStoragePool(virtDBusConnect *connect,
 {
 virStoragePoolPtr storagePool;
 
-if (virtDBusConnectOpen(connect, error) < 0)
+if (!virtDBusConnectOpen(connect, error))
 return NULL;
 
 storagePool = virtDBusUtilVirStoragePoolFromBusPath(connect->connection,
diff --git a/src/storagevol.c b/src/storagevol.c
index e5d1686..6ddff47 100644
--- a/src/storagevol.c
+++ b/src/storagevol.c
@@ -10,7 +10,7 @@ virtDBusStorageVolGetVirStorageVol(virtDBusConnect *connect,
 {
 virStorageVolPtr storageVol;
 
-if (virtDBusConnectOpen(connect, error) < 0)
+if (!virtDBusConnectOpen(connect, error))
 return NULL;
 
 storageVol = virtDBusUtilVirStorageVolFromBusPath(connect->connection,
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list