Re: [libvirt] [dbus PATCH v2 12/17] Implement ListInterfaces method for Connect Interface

2018-07-24 Thread Katerina Koukiou
On Fri, Jul 20, 2018 at 02:34:56PM -0400, Anya Harter wrote:
> Signed-off-by: Anya Harter 
> ---
>  data/org.libvirt.Connect.xml |  6 ++
>  src/connect.c| 38 
>  2 files changed, 44 insertions(+)

Reviewed-by: Katerina Koukiou 


signature.asc
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [dbus PATCH v2 12/17] Implement ListInterfaces method for Connect Interface

2018-07-20 Thread Anya Harter
Signed-off-by: Anya Harter 
---
 data/org.libvirt.Connect.xml |  6 ++
 src/connect.c| 38 
 2 files changed, 44 insertions(+)

diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml
index f690bab..791e1f5 100644
--- a/data/org.libvirt.Connect.xml
+++ b/data/org.libvirt.Connect.xml
@@ -161,6 +161,12 @@
   
   
 
+
+  https://libvirt.org/html/libvirt-libvirt-interface.html#virConnectListAllInterfaces"/>
+  
+  
+
 
   https://libvirt.org/html/libvirt-libvirt-network.html#virConnectListAllNetworks"/>
diff --git a/src/connect.c b/src/connect.c
index 304a56f..9be8264 100644
--- a/src/connect.c
+++ b/src/connect.c
@@ -801,6 +801,43 @@ virtDBusConnectListDomains(GVariant *inArgs,
 *outArgs = g_variant_new_tuple(, 1);
 }
 
+static void
+virtDBusConnectListInterfaces(GVariant *inArgs,
+  GUnixFDList *inFDs G_GNUC_UNUSED,
+  const gchar *objectPath G_GNUC_UNUSED,
+  gpointer userData,
+  GVariant **outArgs,
+  GUnixFDList **outFDs G_GNUC_UNUSED,
+  GError **error)
+{
+virtDBusConnect *connect = userData;
+g_autoptr(virInterfacePtr) interfaces = NULL;
+guint flags;
+GVariantBuilder builder;
+GVariant *ginterfaces;
+
+g_variant_get(inArgs, "(u)", );
+
+if (!virtDBusConnectOpen(connect, error))
+return;
+
+if (virConnectListAllInterfaces(connect->connection, , flags) < 
0)
+return virtDBusUtilSetLastVirtError(error);
+
+g_variant_builder_init(, G_VARIANT_TYPE("ao"));
+
+for (gint i = 0; interfaces[i]; i++) {
+g_autofree gchar *path = NULL;
+path = virtDBusUtilBusPathForVirInterface(interfaces[i],
+  connect->interfacePath);
+
+g_variant_builder_add(, "o", path);
+}
+
+ginterfaces = g_variant_builder_end();
+*outArgs = g_variant_new_tuple(, 1);
+}
+
 static void
 virtDBusConnectListNetworks(GVariant *inArgs,
 GUnixFDList *inFDs G_GNUC_UNUSED,
@@ -1797,6 +1834,7 @@ static virtDBusGDBusMethodTable 
virtDBusConnectMethodTable[] = {
 { "GetSysinfo", virtDBusConnectGetSysinfo },
 { "InterfaceDefineXML", virtDBusConnectInterfaceDefineXML },
 { "ListDomains", virtDBusConnectListDomains },
+{ "ListInterfaces", virtDBusConnectListInterfaces },
 { "ListNetworks", virtDBusConnectListNetworks },
 { "ListNodeDevices", virtDBusConnectListNodeDevices },
 { "ListNWFilters", virtDBusConnectListNWFilters },
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list