Re: [libvirt] [glib v2 0/4] Filesystem config improvements

2015-06-16 Thread Christophe Fergeau
Hey,

Thanks for adding the test!
ACK to patches 1, 3 and 4, one comment in 2.

Christophe

On Tue, Jun 16, 2015 at 10:58:10AM +0200, Cédric Bosdonnat wrote:
> Hi all,
> 
> Here is the previous patch split into a series. The difference with v1 are:
>   * it adds test-gconfig test for file systems
>   * the gvir_config_domain_filesys_set_driver_type fix has been moved to its
> own commit
>   * the gvir_config_domain_filesys_set_driver_format doesn't set the type, the
> user "just" has to make sure he doesn't do stupid things
>   * a test for the new function has been added to test-gconfig
> 
> Cédric Bosdonnat (4):
>   test-gconfig: add filesystem test
>   gvir_config_domain_filesys_set_driver_type: replace the driver node
>   Add loop and nbd filesystem types
>   domain config: add API to set the filesystem image format
> 
>  libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 18 +++-
>  libvirt-gconfig/libvirt-gconfig-domain-filesys.h |  4 +++
>  libvirt-gconfig/libvirt-gconfig.sym  |  5 
>  tests/test-gconfig.c | 36 
> 
>  tests/xml/gconfig-domain-device-filesys.xml  | 15 ++
>  5 files changed, 77 insertions(+), 1 deletion(-)
>  create mode 100644 tests/xml/gconfig-domain-device-filesys.xml
> 
> -- 
> 2.1.4
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list


pgp3Z7V7Tvvuu.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [glib v2 0/4] Filesystem config improvements

2015-06-16 Thread Cédric Bosdonnat
Hi all,

Here is the previous patch split into a series. The difference with v1 are:
  * it adds test-gconfig test for file systems
  * the gvir_config_domain_filesys_set_driver_type fix has been moved to its
own commit
  * the gvir_config_domain_filesys_set_driver_format doesn't set the type, the
user "just" has to make sure he doesn't do stupid things
  * a test for the new function has been added to test-gconfig

Cédric Bosdonnat (4):
  test-gconfig: add filesystem test
  gvir_config_domain_filesys_set_driver_type: replace the driver node
  Add loop and nbd filesystem types
  domain config: add API to set the filesystem image format

 libvirt-gconfig/libvirt-gconfig-domain-filesys.c | 18 +++-
 libvirt-gconfig/libvirt-gconfig-domain-filesys.h |  4 +++
 libvirt-gconfig/libvirt-gconfig.sym  |  5 
 tests/test-gconfig.c | 36 
 tests/xml/gconfig-domain-device-filesys.xml  | 15 ++
 5 files changed, 77 insertions(+), 1 deletion(-)
 create mode 100644 tests/xml/gconfig-domain-device-filesys.xml

-- 
2.1.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list