Re: [libvirt-java PATCH 4/6] rpm: skip junit tests in RHEL-8 build

[Andrea Bolognani]

On Tue, 2020-05-12 at 10:51 +0100, Daniel P. Berrangé wrote:
> +%if 0%{?rhel} != 8
>  BuildRequires:  ant-junit
> +%endif

This can probably be changed to

  %if 0%{?rhel} < 8

under the assumption that packages that have been dropped from RHEL
8 are probably not going to be re-introduced in later major releases.

> +%if 0%{?rhel} != 8
>  ant test
> +%endif

Same here.

With that changed,

  Reviewed-by: Andrea Bolognani 

-- 
Andrea Bolognani / Red Hat / Virtualization

[libvirt-java PATCH 4/6] rpm: skip junit tests in RHEL-8 build

[Daniel P . Berrangé]

Signed-off-by: Daniel P. Berrangé 
---
 libvirt-java.spec.in | 4 
 1 file changed, 4 insertions(+)

diff --git a/libvirt-java.spec.in b/libvirt-java.spec.in
index 034d511..1d7fa43 100644
--- a/libvirt-java.spec.in
+++ b/libvirt-java.spec.in
@@ -20,7 +20,9 @@ Requires:   java >= @java.required@
 Requires:   jpackage-utils
 BuildRequires:  ant
 BuildRequires:  jna
+%if 0%{?rhel} != 8
 BuildRequires:  ant-junit
+%endif
 BuildRequires:  java-devel >= @java.required@
 BuildRequires:  jpackage-utils
 
@@ -68,7 +70,9 @@ cp -r target/javadoc/* 
%{buildroot}%{_javadocdir}/%{name}-%{version}
 %{__ln_s} %{_javadocdir}/%{name}-%{version} %{buildroot}%{_javadocdir}/%{name}
 
 %check
+%if 0%{?rhel} != 8
 ant test
+%endif
 
 %clean
 rm -rf %{buildroot}
-- 
2.26.2