Re: [libvirt PATCH 0/2] qemu: wire up support for rotation rate for disks
On Wed, Mar 31, 2021 at 10:50:24AM +0100, Daniel P. Berrangé wrote: > By default QEMU doesn't report any rotation information to guests, so > guests assume rotational media. This lets the user specify an explicit > speed in RPM, or 1 for SSD. This may allow the user to achieve better > performance for their virtual disks. Note, however, this doesn't mean > that the guest should be given the same setting as the host storage. > It is possible that better performance may be achieved with contrary > settings from the host. Testing is required to determine this on a > case by case basis. Oh, cool that we're finally able to introspect the device capability :). Please link the following BZ in your commits before pushing: https://bugzilla.redhat.com/show_bug.cgi?id=1498955 Regards, Erik
[libvirt PATCH 0/2] qemu: wire up support for rotation rate for disks
By default QEMU doesn't report any rotation information to guests, so guests assume rotational media. This lets the user specify an explicit speed in RPM, or 1 for SSD. This may allow the user to achieve better performance for their virtual disks. Note, however, this doesn't mean that the guest should be given the same setting as the host storage. It is possible that better performance may be achieved with contrary settings from the host. Testing is required to determine this on a case by case basis. Daniel P. Berrangé (2): conf: add support for disk "rotation_rate" property qemu: implement setting of rotation rate for SCSI/IDE disks docs/formatdomain.rst | 13 - docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c| 11 src/conf/domain_conf.h| 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 3 + src/qemu/qemu_validate.c | 22 .../caps_2.12.0.aarch64.xml | 1 + .../caps_4.0.0.aarch64.xml| 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml| 1 + .../caps_4.0.0.riscv64.xml| 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml| 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml| 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml| 1 + .../caps_5.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.aarch64.xml| 1 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + .../caps_5.2.0.riscv64.xml| 1 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + .../disk-rotation.x86_64-latest.args | 56 +++ tests/qemuxml2argvdata/disk-rotation.xml | 38 + tests/qemuxml2argvtest.c | 1 + .../disk-rotation.x86_64-latest.xml | 55 ++ tests/qemuxml2xmltest.c | 1 + 37 files changed, 230 insertions(+), 3 deletions(-) create mode 100644 tests/qemuxml2argvdata/disk-rotation.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-rotation.xml create mode 100644 tests/qemuxml2xmloutdata/disk-rotation.x86_64-latest.xml -- 2.30.2
