Re: [libvirt PATCH 4/5] nwfilter: remove decl of virNWFilterCreateVarHashmap

2022-02-28 Thread Laine Stump 

On 2/25/22 10:30 AM, Daniel P. Berrangé wrote:

This method doesn't exist since

   commit d1a7c08eb145d8b9d9c4a268f43b1590049a
   Author: Daniel P. Berrangé 
   Date:   Thu Apr 26 12:26:51 2018 +0100

 nwfilter: convert the gentech driver code to use virNWFilterBindingDefPtr

Signed-off-by: Daniel P. Berrangé 


The proof is in the successful compile without it :-)

Reviewed-by: Laine Stump

[libvirt PATCH 4/5] nwfilter: remove decl of virNWFilterCreateVarHashmap

2022-02-25 Thread Daniel P . Berrangé 
This method doesn't exist since

  commit d1a7c08eb145d8b9d9c4a268f43b1590049a
  Author: Daniel P. Berrangé 
  Date:   Thu Apr 26 12:26:51 2018 +0100

nwfilter: convert the gentech driver code to use virNWFilterBindingDefPtr

Signed-off-by: Daniel P. Berrangé 
---
 src/nwfilter/nwfilter_gentech_driver.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/nwfilter/nwfilter_gentech_driver.h 
b/src/nwfilter/nwfilter_gentech_driver.h
index 56d1d7a80a..74f8a4496b 100644
--- a/src/nwfilter/nwfilter_gentech_driver.h
+++ b/src/nwfilter/nwfilter_gentech_driver.h
@@ -49,8 +49,5 @@ int virNWFilterInstantiateFilterLate(virNWFilterDriverState 
*driver,
 
 int virNWFilterTeardownFilter(virNWFilterBindingDef *binding);
 
-GHashTable *virNWFilterCreateVarHashmap(const char *macaddr,
-const virNWFilterVarValue *value);
-
 int virNWFilterBuildAll(virNWFilterDriverState *driver,
 bool newFilters);
-- 
2.35.1