Re: [libvirt PATCH 5/4] meson: Don't check whether /usr/local/bin/grep is GNU grep

[Erik Skultety]

On Thu, Apr 01, 2021 at 02:17:14PM +0200, Andrea Bolognani wrote:
> Since /usr/local is where ports live, it's reasonable to assume
> that a grep binary found in there will have been installed via
> ports and will thus be GNU grep.
> 
> Suggested-by: Erik Skultety 
> Signed-off-by: Andrea Bolognani 
> ---

Feels weird ACKing this, but FWIW:
Reviewed-by: Erik Skultety 

[libvirt PATCH 5/4] meson: Don't check whether /usr/local/bin/grep is GNU grep

[Andrea Bolognani]

Since /usr/local is where ports live, it's reasonable to assume
that a grep binary found in there will have been installed via
ports and will thus be GNU grep.

Suggested-by: Erik Skultety 
Signed-off-by: Andrea Bolognani 
---
 build-aux/meson.build | 4 
 1 file changed, 4 deletions(-)

diff --git a/build-aux/meson.build b/build-aux/meson.build
index 1095982397..e491bdeebc 100644
--- a/build-aux/meson.build
+++ b/build-aux/meson.build
@@ -26,10 +26,6 @@ if host_machine.system() == 'freebsd'
 if not grep_prog.found()
   error('GNU grep not found')
 endif
-grep_cmd = run_command(grep_prog, '--version')
-if grep_cmd.stdout().startswith('grep (BSD grep')
-  error('GNU grep not found')
-endif
   endif
 elif host_machine.system() == 'darwin'
   grep_prog = find_program('ggrep')
-- 
2.26.3