Re: [libvirt PATCH 7/9] spec: Drop s390 architecture from conditionals

[Thomas Huth]

On 05/10/2020 20.40, Andrea Bolognani wrote:
> Neither Fedora nor RHEL build packages on this architecture.
> 
> Signed-off-by: Andrea Bolognani 
> ---
>  libvirt.spec.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index d8f689e651..e036307d30 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -109,12 +109,12 @@
>  %endif
>  
>  # Numactl is not available on many non-x86 archs
> -%ifarch s390 s390x %{arm} riscv64
> +%ifarch s390x %{arm} riscv64
>  %define with_numactl 0
>  %endif
>  
>  # zfs-fuse is not available on some architectures
> -%ifarch s390 s390x aarch64 riscv64
> +%ifarch s390x aarch64 riscv64
>  %define with_storage_zfs 0
>  %endif
>  
> @@ -179,7 +179,7 @@
>  %if %{with_qemu} || %{with_lxc}
>  # numad is used to manage the CPU and memory placement dynamically,
>  # it's not available on many non-x86 architectures.
> -%ifnarch s390 s390x %{arm} riscv64
> +%ifnarch s390x %{arm} riscv64
>  %define with_numad0%{!?_without_numad:1}
>  %endif
>  %endif
> 

Reviewed-by: Thomas Huth 

Re: [libvirt PATCH 7/9] spec: Drop s390 architecture from conditionals

[Neal Gompa]

On Mon, Oct 5, 2020 at 2:41 PM Andrea Bolognani  wrote:
>
> Neither Fedora nor RHEL build packages on this architecture.
>
> Signed-off-by: Andrea Bolognani 
> ---
>  libvirt.spec.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index d8f689e651..e036307d30 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -109,12 +109,12 @@
>  %endif
>
>  # Numactl is not available on many non-x86 archs
> -%ifarch s390 s390x %{arm} riscv64
> +%ifarch s390x %{arm} riscv64
>  %define with_numactl 0
>  %endif
>
>  # zfs-fuse is not available on some architectures
> -%ifarch s390 s390x aarch64 riscv64
> +%ifarch s390x aarch64 riscv64
>  %define with_storage_zfs 0
>  %endif
>
> @@ -179,7 +179,7 @@
>  %if %{with_qemu} || %{with_lxc}
>  # numad is used to manage the CPU and memory placement dynamically,
>  # it's not available on many non-x86 architectures.
> -%ifnarch s390 s390x %{arm} riscv64
> +%ifnarch s390x %{arm} riscv64
>  %define with_numad0%{!?_without_numad:1}
>  %endif
>  %endif
> --
> 2.26.2
>

Good riddance to bad architectures...

Reviewed-by: Neal Gompa 


-- 
真実はいつも一つ！/ Always, there's only one truth!

[libvirt PATCH 7/9] spec: Drop s390 architecture from conditionals

[Andrea Bolognani]

Neither Fedora nor RHEL build packages on this architecture.

Signed-off-by: Andrea Bolognani 
---
 libvirt.spec.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index d8f689e651..e036307d30 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -109,12 +109,12 @@
 %endif
 
 # Numactl is not available on many non-x86 archs
-%ifarch s390 s390x %{arm} riscv64
+%ifarch s390x %{arm} riscv64
 %define with_numactl 0
 %endif
 
 # zfs-fuse is not available on some architectures
-%ifarch s390 s390x aarch64 riscv64
+%ifarch s390x aarch64 riscv64
 %define with_storage_zfs 0
 %endif
 
@@ -179,7 +179,7 @@
 %if %{with_qemu} || %{with_lxc}
 # numad is used to manage the CPU and memory placement dynamically,
 # it's not available on many non-x86 architectures.
-%ifnarch s390 s390x %{arm} riscv64
+%ifnarch s390x %{arm} riscv64
 %define with_numad0%{!?_without_numad:1}
 %endif
 %endif
-- 
2.26.2