Re: [libvirt PATCH v2 0/4] qemu: Add support for VMware paravirtual SCSI controller

2020-05-13 Thread Peter Krempa 
On Tue, May 12, 2020 at 21:55:44 -0400, Chris Jester-Young wrote:
> QEMU has supported pvscsi, the VMware paravirtual SCSI controller, since
> 2013, but libvirt does not currently expose support for it.  Adding such
> support is straightforward.
> 
> I have tested it with a Windows 10 guest, and the official VMware driver
> supports it with no issues. However, booting only works with SeaBIOS
> (tested) and the pre-release version of OVMF (not tested yet).

I've tested it with centos-8.

Series:

Reviewed-by: Peter Krempa 

and pushed to master. Thanks for the patches!

[libvirt PATCH v2 0/4] qemu: Add support for VMware paravirtual SCSI controller

2020-05-12 Thread Chris Jester-Young 
QEMU has supported pvscsi, the VMware paravirtual SCSI controller, since
2013, but libvirt does not currently expose support for it.  Adding such
support is straightforward.

I have tested it with a Windows 10 guest, and the official VMware driver
supports it with no issues. However, booting only works with SeaBIOS
(tested) and the pre-release version of OVMF (not tested yet).

Chris Jester-Young (4):
  qemu: pvscsi: Add capability
  qemu: pvscsi: Add support for vmpvscsi controller model
  tests: qemuxml2xmltest: Convert disk-scsi to DO_TEST_CAPS_LATEST
  tests: qemuxml2argvtest: Add vmpvscsi to disk-scsi test

 src/qemu/qemu_capabilities.c  |  2 +
 src/qemu/qemu_capabilities.h  |  1 +
 src/qemu/qemu_command.c   |  4 +-
 src/qemu/qemu_validate.c  |  9 -
 .../caps_1.5.3.x86_64.xml |  1 +
 .../caps_1.6.0.x86_64.xml |  1 +
 .../caps_1.7.0.x86_64.xml |  1 +
 .../caps_2.1.1.x86_64.xml |  1 +
 .../caps_2.10.0.aarch64.xml   |  1 +
 .../caps_2.10.0.ppc64.xml |  1 +
 .../caps_2.10.0.x86_64.xml|  1 +
 .../caps_2.11.0.x86_64.xml|  1 +
 .../caps_2.12.0.aarch64.xml   |  1 +
 .../caps_2.12.0.ppc64.xml |  1 +
 .../caps_2.12.0.x86_64.xml|  1 +
 .../caps_2.4.0.x86_64.xml |  1 +
 .../caps_2.5.0.x86_64.xml |  1 +
 .../caps_2.6.0.aarch64.xml|  1 +
 .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml |  1 +
 .../caps_2.6.0.x86_64.xml |  1 +
 .../caps_2.7.0.x86_64.xml |  1 +
 .../caps_2.8.0.x86_64.xml |  1 +
 .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml |  1 +
 .../caps_2.9.0.x86_64.xml |  1 +
 .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml |  1 +
 .../caps_3.0.0.x86_64.xml |  1 +
 .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml |  1 +
 .../caps_3.1.0.x86_64.xml |  1 +
 .../caps_4.0.0.aarch64.xml|  1 +
 .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml |  1 +
 .../caps_4.0.0.riscv32.xml|  1 +
 .../caps_4.0.0.riscv64.xml|  1 +
 .../caps_4.0.0.x86_64.xml |  1 +
 .../caps_4.1.0.x86_64.xml |  1 +
 .../caps_4.2.0.aarch64.xml|  1 +
 .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml |  1 +
 .../caps_4.2.0.x86_64.xml |  1 +
 .../caps_5.0.0.aarch64.xml|  1 +
 .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml |  1 +
 .../caps_5.0.0.riscv64.xml|  1 +
 .../caps_5.0.0.x86_64.xml |  1 +
 .../caps_5.1.0.x86_64.xml |  1 +
 .../disk-scsi.x86_64-latest.args  | 37 +++
 tests/qemuxml2argvdata/disk-scsi.xml  |  6 +++
 ...k-scsi.xml => disk-scsi.x86_64-latest.xml} | 20 --
 tests/qemuxml2xmltest.c   |  3 +-
 46 files changed, 97 insertions(+), 23 deletions(-)
 rename tests/qemuxml2xmloutdata/{disk-scsi.xml => disk-scsi.x86_64-latest.xml} 
(83%)

-- 
2.25.1