Re: [libvirt PATCH v2 0/9] Second take on slirp-helper & dbus-vmstate
On 2/25/20 10:55 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Hi, The series "[libvirt] [PATCH v2 00/23] Use a slirp helper process" has been merged and partially reverted. Meanwhile, qemu dbus-vmstate design has been changed and merged upstream. This new series fixes the slirp-helper support. The significant change is that dbus-vmstate now requires a bus (instead of the earlier peer-to-peer connection). The current series doesn't attempt to enforce strict policies on the bus. As long as you can connect to the bus, you can send/receive from/to anyone. A follow-up series should implement the recommendations from https://qemu.readthedocs.io/en/latest/interop/dbus.html#security. The libslirp-rs slirp-helper hasn't yet received an official release. For testing, you may: $ cargo install --features=all --git https://gitlab.freedesktop.org/slirp/libslirp-rs The resulting binary should be ~/.cargo/bin/slirp-helper, so qemu.conf slirp_helper location should be adjusted. With that in place, a VM with user networking (slirp) should now start with the helper process. thanks v2: - merge most suggestions/changes from Michal Privoznik review of v1. - added "WIP: qemu_slirp: update to follow current spec" Marc-André Lureau (9): qemu: remove dbus-vmstate code qemu-conf: add configurable dbus-daemon location qemu-conf: add dbusStateDir qemu: add a DBus daemon helper unit domain: save/restore the state of dbus-daemon running qemu: prepare and stop the dbus daemon qemu: add dbus-vmstate helper migration support qemu-slirp: register helper for migration WIP: qemu-slirp: update to follow current spec m4/virt-driver-qemu.m4 | 6 + src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 3 + src/qemu/qemu_alias.c | 17 +- src/qemu/qemu_alias.h | 3 +- src/qemu/qemu_command.c| 81 +++-- src/qemu/qemu_command.h| 6 +- src/qemu/qemu_conf.c | 7 + src/qemu/qemu_conf.h | 2 + src/qemu/qemu_dbus.c | 264 + src/qemu/qemu_dbus.h | 25 ++- src/qemu/qemu_domain.c | 30 ++-- src/qemu/qemu_domain.h | 8 +- src/qemu/qemu_extdevice.c | 4 +- src/qemu/qemu_hotplug.c| 165 +- src/qemu/qemu_hotplug.h| 17 +- src/qemu/qemu_migration.c | 57 ++- src/qemu/qemu_monitor.c| 21 +++ src/qemu/qemu_monitor.h| 3 + src/qemu/qemu_monitor_json.c | 15 ++ src/qemu/qemu_monitor_json.h | 5 + src/qemu/qemu_process.c| 6 + src/qemu/qemu_slirp.c | 157 +++-- src/qemu/qemu_slirp.h | 4 +- src/qemu/test_libvirtd_qemu.aug.in | 1 + 25 files changed, 544 insertions(+), 364 deletions(-) I've fixed all the small bits I've raised locally. Reviewed-by: Michal Privoznik However, as I mention in 4/9 I need to merge some other patches first. I will merge these after that. Michal
Re: [libvirt PATCH v2 0/9] Second take on slirp-helper & dbus-vmstate
On Tue, Feb 25, 2020 at 10:55 AM wrote: > > From: Marc-André Lureau > > Hi, > > The series "[libvirt] [PATCH v2 00/23] Use a slirp helper process" has > been merged and partially reverted. Meanwhile, qemu dbus-vmstate > design has been changed and merged upstream. > > This new series fixes the slirp-helper support. The significant change > is that dbus-vmstate now requires a bus (instead of the earlier > peer-to-peer connection). The current series doesn't attempt to > enforce strict policies on the bus. As long as you can connect to the > bus, you can send/receive from/to anyone. A follow-up series should > implement the recommendations from > https://qemu.readthedocs.io/en/latest/interop/dbus.html#security. > > The libslirp-rs slirp-helper hasn't yet received an official release. > For testing, you may: > $ cargo install --features=all --git > https://gitlab.freedesktop.org/slirp/libslirp-rs > > The resulting binary should be ~/.cargo/bin/slirp-helper, so qemu.conf > slirp_helper location should be adjusted. With that in place, a VM > with user networking (slirp) should now start with the helper process. > > thanks > > v2: > - merge most suggestions/changes from Michal Privoznik review of v1. > - added "WIP: qemu_slirp: update to follow current spec" > > Marc-André Lureau (9): > qemu: remove dbus-vmstate code > qemu-conf: add configurable dbus-daemon location > qemu-conf: add dbusStateDir > qemu: add a DBus daemon helper unit > domain: save/restore the state of dbus-daemon running > qemu: prepare and stop the dbus daemon > qemu: add dbus-vmstate helper migration support > qemu-slirp: register helper for migration > WIP: qemu-slirp: update to follow current spec > ping ? thanks > m4/virt-driver-qemu.m4 | 6 + > src/qemu/libvirtd_qemu.aug | 1 + > src/qemu/qemu.conf | 3 + > src/qemu/qemu_alias.c | 17 +- > src/qemu/qemu_alias.h | 3 +- > src/qemu/qemu_command.c| 81 +++-- > src/qemu/qemu_command.h| 6 +- > src/qemu/qemu_conf.c | 7 + > src/qemu/qemu_conf.h | 2 + > src/qemu/qemu_dbus.c | 264 + > src/qemu/qemu_dbus.h | 25 ++- > src/qemu/qemu_domain.c | 30 ++-- > src/qemu/qemu_domain.h | 8 +- > src/qemu/qemu_extdevice.c | 4 +- > src/qemu/qemu_hotplug.c| 165 +- > src/qemu/qemu_hotplug.h| 17 +- > src/qemu/qemu_migration.c | 57 ++- > src/qemu/qemu_monitor.c| 21 +++ > src/qemu/qemu_monitor.h| 3 + > src/qemu/qemu_monitor_json.c | 15 ++ > src/qemu/qemu_monitor_json.h | 5 + > src/qemu/qemu_process.c| 6 + > src/qemu/qemu_slirp.c | 157 +++-- > src/qemu/qemu_slirp.h | 4 +- > src/qemu/test_libvirtd_qemu.aug.in | 1 + > 25 files changed, 544 insertions(+), 364 deletions(-) > > -- > 2.25.0.rc2.1.g09a9a1a997 > -- Marc-André Lureau
[libvirt PATCH v2 0/9] Second take on slirp-helper & dbus-vmstate
From: Marc-André Lureau Hi, The series "[libvirt] [PATCH v2 00/23] Use a slirp helper process" has been merged and partially reverted. Meanwhile, qemu dbus-vmstate design has been changed and merged upstream. This new series fixes the slirp-helper support. The significant change is that dbus-vmstate now requires a bus (instead of the earlier peer-to-peer connection). The current series doesn't attempt to enforce strict policies on the bus. As long as you can connect to the bus, you can send/receive from/to anyone. A follow-up series should implement the recommendations from https://qemu.readthedocs.io/en/latest/interop/dbus.html#security. The libslirp-rs slirp-helper hasn't yet received an official release. For testing, you may: $ cargo install --features=all --git https://gitlab.freedesktop.org/slirp/libslirp-rs The resulting binary should be ~/.cargo/bin/slirp-helper, so qemu.conf slirp_helper location should be adjusted. With that in place, a VM with user networking (slirp) should now start with the helper process. thanks v2: - merge most suggestions/changes from Michal Privoznik review of v1. - added "WIP: qemu_slirp: update to follow current spec" Marc-André Lureau (9): qemu: remove dbus-vmstate code qemu-conf: add configurable dbus-daemon location qemu-conf: add dbusStateDir qemu: add a DBus daemon helper unit domain: save/restore the state of dbus-daemon running qemu: prepare and stop the dbus daemon qemu: add dbus-vmstate helper migration support qemu-slirp: register helper for migration WIP: qemu-slirp: update to follow current spec m4/virt-driver-qemu.m4 | 6 + src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 3 + src/qemu/qemu_alias.c | 17 +- src/qemu/qemu_alias.h | 3 +- src/qemu/qemu_command.c| 81 +++-- src/qemu/qemu_command.h| 6 +- src/qemu/qemu_conf.c | 7 + src/qemu/qemu_conf.h | 2 + src/qemu/qemu_dbus.c | 264 + src/qemu/qemu_dbus.h | 25 ++- src/qemu/qemu_domain.c | 30 ++-- src/qemu/qemu_domain.h | 8 +- src/qemu/qemu_extdevice.c | 4 +- src/qemu/qemu_hotplug.c| 165 +- src/qemu/qemu_hotplug.h| 17 +- src/qemu/qemu_migration.c | 57 ++- src/qemu/qemu_monitor.c| 21 +++ src/qemu/qemu_monitor.h| 3 + src/qemu/qemu_monitor_json.c | 15 ++ src/qemu/qemu_monitor_json.h | 5 + src/qemu/qemu_process.c| 6 + src/qemu/qemu_slirp.c | 157 +++-- src/qemu/qemu_slirp.h | 4 +- src/qemu/test_libvirtd_qemu.aug.in | 1 + 25 files changed, 544 insertions(+), 364 deletions(-) -- 2.25.0.rc2.1.g09a9a1a997
