Re: [libvirt PATCH v2 9/9] gitlab: add job for building latest potfile
On Tue, 2020-03-24 at 18:23 +, Daniel P. Berrangé wrote: > On Tue, Mar 24, 2020 at 06:51:10PM +0100, Andrea Bolognani wrote: > > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > > > +# This artifact published by this job is downloaded to push to Weblate > > > +# for translation usage: > > > +# > > > https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=potfile > > > +potfile: > > > + stage: prebuild > > > + only: > > > +refs: > > > + - master > > > > As discussed in patch 6/9, it would make more sense for this to be > > in a postbuild stage, after all other builds have succeeded, than > > in a prebuild stage. > > We want the pot file build to run regardless of whether the other > builds succeed. There may be transient failures with builds and > we want to publish the pot & website content regardless, once it > is in master. Makes sense. Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization
Re: [libvirt PATCH v2 9/9] gitlab: add job for building latest potfile
On Tue, Mar 24, 2020 at 04:24:05PM +, Daniel P. Berrangé wrote: > Whenever there is a change to the translatable strings we need to push > a new libvirt.pot to weblate. This only needs to be done when code > merges into git master, so the job is restricted to that branch. > > Signed-off-by: Daniel P. Berrangé > --- > .gitlab-ci.yml | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 2286d28707..08e8df5d25 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -136,3 +136,29 @@ website: > expire_in: 30 days > paths: >- website > + > + > +# This artifact published by this job is downloaded to push to Weblate > +# for translation usage: > +# > https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=potfile > +potfile: > + stage: prebuild > + only: > +refs: > + - master Actually, my fingers were too fast...same as in one of the previous patches: only: - master should be sufficient... Erik
Re: [libvirt PATCH v2 9/9] gitlab: add job for building latest potfile
On Tue, Mar 24, 2020 at 06:23:19PM +, Daniel P. Berrangé wrote: > On Tue, Mar 24, 2020 at 06:51:10PM +0100, Andrea Bolognani wrote: > > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > > > +# This artifact published by this job is downloaded to push to Weblate > > > +# for translation usage: > > > +# > > > https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=potfile > > > +potfile: > > > + stage: prebuild > > > + only: > > > +refs: > > > + - master > > > > As discussed in patch 6/9, it would make more sense for this to be > > in a postbuild stage, after all other builds have succeeded, than > > in a prebuild stage. > > We want the pot file build to run regardless of whether the other > builds succeed. There may be transient failures with builds and > we want to publish the pot & website content regardless, once it > is in master. That explanation makes sense. Reviewed-by: Erik Skultety
Re: [libvirt PATCH v2 9/9] gitlab: add job for building latest potfile
On Tue, Mar 24, 2020 at 06:51:10PM +0100, Andrea Bolognani wrote: > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > > +# This artifact published by this job is downloaded to push to Weblate > > +# for translation usage: > > +# > > https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=potfile > > +potfile: > > + stage: prebuild > > + only: > > +refs: > > + - master > > As discussed in patch 6/9, it would make more sense for this to be > in a postbuild stage, after all other builds have succeeded, than > in a prebuild stage. We want the pot file build to run regardless of whether the other builds succeed. There may be transient failures with builds and we want to publish the pot & website content regardless, once it is in master. Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
Re: [libvirt PATCH v2 9/9] gitlab: add job for building latest potfile
On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote: > +# This artifact published by this job is downloaded to push to Weblate > +# for translation usage: > +# > https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=potfile > +potfile: > + stage: prebuild > + only: > +refs: > + - master As discussed in patch 6/9, it would make more sense for this to be in a postbuild stage, after all other builds have succeeded, than in a prebuild stage. -- Andrea Bolognani / Red Hat / Virtualization
[libvirt PATCH v2 9/9] gitlab: add job for building latest potfile
Whenever there is a change to the translatable strings we need to push a new libvirt.pot to weblate. This only needs to be done when code merges into git master, so the job is restricted to that branch. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 26 ++ 1 file changed, 26 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 2286d28707..08e8df5d25 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -136,3 +136,29 @@ website: expire_in: 30 days paths: - website + + +# This artifact published by this job is downloaded to push to Weblate +# for translation usage: +# https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=potfile +potfile: + stage: prebuild + only: +refs: + - master + script: +- mkdir build +- cd build +- ../autogen.sh || (cat config.log && exit 1) +- $MAKE -j $(getconf _NPROCESSORS_ONLN) -C src generated-sources +- $MAKE -j $(getconf _NPROCESSORS_ONLN) -C po libvirt.pot +- cd .. +- mv build/po/libvirt.pot libvirt.pot + image: quay.io/libvirt/buildenv-libvirt-fedora-31:latest + artifacts: +expose_as: 'Potfile' +name: 'potfile' +when: on_success +expire_in: 30 days +paths: + - libvirt.pot -- 2.24.1
