Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2
On Mon, Aug 27, 2012 at 11:32:11AM -0500, Doug Goldstein wrote:
On Mon, Aug 27, 2012 at 4:57 AM, Justin Clift jcl...@redhat.com wrote:
On 27/08/2012, at 1:00 PM, Daniel Veillard wrote:
I tagged the rc2 in the git tree and pushed tarball and rpms to
the usual place:
ftp://libvirt.org/libvirt/
it should include the various fixes that were made on top of rc1
and fix the compilation problem exposed on OS-X, as well as picking
libnl3 if available,
please give it a try and report, I am still shooting for a final
release this Wednesday,
Still a no go on OSX. Different error this time:
...
libvirtd.c: In function 'main':
libvirtd.c:1316: error: 'NETLINK_ROUTE' undeclared (first use in this
function)
libvirtd.c:1316: error: (Each undeclared identifier is reported only once
libvirtd.c:1316: error: for each function it appears in.)
libvirtd.c:1322: error: 'NETLINK_KOBJECT_UEVENT' undeclared (first use in
this function)
make[3]: *** [libvirtd-libvirtd.o] Error 1
make[3]: *** Waiting for unfinished jobs
Any ideas?
+ Justin
You can try something like the following to get you a little farther
and see if it fails farther on. Just trying to see if we can get Mac
OS X built and see what changes need to happen before 0.10.0 goes out
final, not necessary proper patches just yet.
diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h
index 1982dae..c3f3e81 100644
--- a/src/util/virnetlink.h
+++ b/src/util/virnetlink.h
@@ -34,6 +34,9 @@ struct nl_msg;
struct sockaddr_nl;
struct nlattr;
+#define NETLINK_ROUTE 0 /* Routing/device hook */
+#define NETLINK_KOBJECT_UEVENT 15 /* Kernel messages to userspace */
+
# endif /* __linux__ */
int virNetlinkStartup(void);
I don't like too much the idea of adding kernel defines in our headers.
Basically this is all due to commits
d57567940153147f4d43875fb92c3030b3178b03 and
080bf330e3749d94ebe094f8deca0e3e67d3f2fe
The fact that it breaks only in daemon.c, i.e. after the library
compiled is a good infocation that the guards
#if WITH_VIRTUALPORT in src/util/virnetdevvportprofile.c
#if WITH_MACVTAP in src/util/virnetdevmacvlan.c
and
#if defined(__linux__) defined(HAVE_LIBNL) defined(IFLA_VF_MAX)
in src/util/virnetdev.c
seems sufficient to avoid the portability problem in those files
and the remaining problem is really about daemon/libvirtd.c and
I would suggest a fix along those lines:
Daniel
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 19dd26b..352d4fe 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -1312,17 +1312,21 @@ int main(int argc, char **argv) {
goto cleanup;
}
+#if defined(__linux__) defined(NETLINK_ROUTE)
/* Register the netlink event service for NETLINK_ROUTE */
if (virNetlinkEventServiceStart(NETLINK_ROUTE, 0) 0) {
ret = VIR_DAEMON_ERR_NETWORK;
goto cleanup;
}
+#endif
+#if defined(__linux__) defined(NETLINK_KOBJECT_UEVENT)
/* Register the netlink event service for NETLINK_KOBJECT_UEVENT */
if (virNetlinkEventServiceStart(NETLINK_KOBJECT_UEVENT, 1) 0) {
ret = VIR_DAEMON_ERR_NETWORK;
goto cleanup;
}
+#endif
/* Run event loop. */
virNetServerRun(srv);
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2
On 28/08/2012, at 6:05 PM, Daniel Veillard wrote:
snip
I would suggest a fix along those lines:
Daniel
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 19dd26b..352d4fe 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -1312,17 +1312,21 @@ int main(int argc, char **argv) {
goto cleanup;
}
+#if defined(__linux__) defined(NETLINK_ROUTE)
/* Register the netlink event service for NETLINK_ROUTE */
if (virNetlinkEventServiceStart(NETLINK_ROUTE, 0) 0) {
ret = VIR_DAEMON_ERR_NETWORK;
goto cleanup;
}
+#endif
+#if defined(__linux__) defined(NETLINK_KOBJECT_UEVENT)
/* Register the netlink event service for NETLINK_KOBJECT_UEVENT */
if (virNetlinkEventServiceStart(NETLINK_KOBJECT_UEVENT, 1) 0) {
ret = VIR_DAEMON_ERR_NETWORK;
goto cleanup;
}
+#endif
/* Run event loop. */
virNetServerRun(srv);
Just tested this to be absolutely sure, and it definitely works too.
ie. as alternative approach to Doug's patch.
+ Justin
--
Aeolus Community Manager
http://www.aeolusproject.org
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On Tue, Aug 28, 2012 at 04:05:36PM +0800, Daniel Veillard thus spake:
I don't like too much the idea of adding kernel defines in our headers.
Basically this is all due to commits
d57567940153147f4d43875fb92c3030b3178b03 and
080bf330e3749d94ebe094f8deca0e3e67d3f2fe
The fact that it breaks only in daemon.c, i.e. after the library
compiled is a good infocation that the guards
#if WITH_VIRTUALPORT in src/util/virnetdevvportprofile.c
#if WITH_MACVTAP in src/util/virnetdevmacvlan.c
and
#if defined(__linux__) defined(HAVE_LIBNL) defined(IFLA_VF_MAX)
in src/util/virnetdev.c
seems sufficient to avoid the portability problem in those files
and the remaining problem is really about daemon/libvirtd.c and
I would suggest a fix along those lines:
Daniel
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 19dd26b..352d4fe 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -1312,17 +1312,21 @@ int main(int argc, char **argv) {
goto cleanup;
}
+#if defined(__linux__) defined(NETLINK_ROUTE)
/* Register the netlink event service for NETLINK_ROUTE */
if (virNetlinkEventServiceStart(NETLINK_ROUTE, 0) 0) {
ret = VIR_DAEMON_ERR_NETWORK;
goto cleanup;
}
+#endif
+#if defined(__linux__) defined(NETLINK_KOBJECT_UEVENT)
/* Register the netlink event service for NETLINK_KOBJECT_UEVENT */
if (virNetlinkEventServiceStart(NETLINK_KOBJECT_UEVENT, 1) 0) {
ret = VIR_DAEMON_ERR_NETWORK;
goto cleanup;
}
+#endif
/* Run event loop. */
virNetServerRun(srv);
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
This is building as expected with your new patch for FreeBSD. Here is a link
to the build logs.
https://redports.org/buildarchive/20120828164025-20179/
- -jgh
- --
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html
E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.19 (FreeBSD)
iF4EAREIAAYFAlA8+WYACgkQXpKtZoyM+6WK9wD9HXb5AybTrroQJTLseuRLvr7p
scRUSIA7lfSFM7s2lxUA/0B5X878TeDFk9IUaXgOWOsbjt6z28+m/1LuH9XcHHHa
=MCSJ
-END PGP SIGNATURE-
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2
On Mon, Aug 27, 2012 at 11:32:11AM -0500, Doug Goldstein thus spake: On Mon, Aug 27, 2012 at 4:57 AM, Justin Clift jcl...@redhat.com wrote: On 27/08/2012, at 1:00 PM, Daniel Veillard wrote: I tagged the rc2 in the git tree and pushed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ it should include the various fixes that were made on top of rc1 and fix the compilation problem exposed on OS-X, as well as picking libnl3 if available, please give it a try and report, I am still shooting for a final release this Wednesday, Still a no go on OSX. Different error this time: ... libvirtd.c: In function 'main': libvirtd.c:1316: error: 'NETLINK_ROUTE' undeclared (first use in this function) libvirtd.c:1316: error: (Each undeclared identifier is reported only once libvirtd.c:1316: error: for each function it appears in.) libvirtd.c:1322: error: 'NETLINK_KOBJECT_UEVENT' undeclared (first use in this function) make[3]: *** [libvirtd-libvirtd.o] Error 1 make[3]: *** Waiting for unfinished jobs Any ideas? + Justin You can try something like the following to get you a little farther and see if it fails farther on. Just trying to see if we can get Mac OS X built and see what changes need to happen before 0.10.0 goes out final, not necessary proper patches just yet. diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h index 1982dae..c3f3e81 100644 --- a/src/util/virnetlink.h +++ b/src/util/virnetlink.h @@ -34,6 +34,9 @@ struct nl_msg; struct sockaddr_nl; struct nlattr; +#define NETLINK_ROUTE 0 /* Routing/device hook */ +#define NETLINK_KOBJECT_UEVENT 15 /* Kernel messages to userspace */ + # endif /* __linux__ */ int virNetlinkStartup(void); -- Doug Goldstein Adding this patch to FreeBSD worked just fine, so this should work for MacOSX, as well. https://redports.org/buildarchive/20120827180312-44416/ -jgh -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2
On Tue, Aug 28, 2012 at 10:01:27AM -0700, Jason Helfman wrote:
On Tue, Aug 28, 2012 at 04:05:36PM +0800, Daniel Veillard thus spake:
I don't like too much the idea of adding kernel defines in our headers.
Basically this is all due to commits
d57567940153147f4d43875fb92c3030b3178b03 and
080bf330e3749d94ebe094f8deca0e3e67d3f2fe
The fact that it breaks only in daemon.c, i.e. after the library
compiled is a good infocation that the guards
#if WITH_VIRTUALPORT in src/util/virnetdevvportprofile.c
#if WITH_MACVTAP in src/util/virnetdevmacvlan.c
and
#if defined(__linux__) defined(HAVE_LIBNL) defined(IFLA_VF_MAX)
in src/util/virnetdev.c
seems sufficient to avoid the portability problem in those files
and the remaining problem is really about daemon/libvirtd.c and
I would suggest a fix along those lines:
Daniel
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 19dd26b..352d4fe 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -1312,17 +1312,21 @@ int main(int argc, char **argv) {
goto cleanup;
}
+#if defined(__linux__) defined(NETLINK_ROUTE)
/* Register the netlink event service for NETLINK_ROUTE */
if (virNetlinkEventServiceStart(NETLINK_ROUTE, 0) 0) {
ret = VIR_DAEMON_ERR_NETWORK;
goto cleanup;
}
+#endif
+#if defined(__linux__) defined(NETLINK_KOBJECT_UEVENT)
/* Register the netlink event service for NETLINK_KOBJECT_UEVENT */
if (virNetlinkEventServiceStart(NETLINK_KOBJECT_UEVENT, 1) 0) {
ret = VIR_DAEMON_ERR_NETWORK;
goto cleanup;
}
+#endif
/* Run event loop. */
virNetServerRun(srv);
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
This is building as expected with your new patch for FreeBSD. Here is a link
to the build logs.
https://redports.org/buildarchive/20120828164025-20179/
Thanks Justin and Jason for the feedback !
I pushed as a result :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2
On 27/08/2012, at 1:00 PM, Daniel Veillard wrote: I tagged the rc2 in the git tree and pushed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ it should include the various fixes that were made on top of rc1 and fix the compilation problem exposed on OS-X, as well as picking libnl3 if available, please give it a try and report, I am still shooting for a final release this Wednesday, Still a no go on OSX. Different error this time: ... libvirtd.c: In function 'main': libvirtd.c:1316: error: 'NETLINK_ROUTE' undeclared (first use in this function) libvirtd.c:1316: error: (Each undeclared identifier is reported only once libvirtd.c:1316: error: for each function it appears in.) libvirtd.c:1322: error: 'NETLINK_KOBJECT_UEVENT' undeclared (first use in this function) make[3]: *** [libvirtd-libvirtd.o] Error 1 make[3]: *** Waiting for unfinished jobs Any ideas? + Justin -- Aeolus Community Manager http://www.aeolusproject.org -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2
On Mon, Aug 27, 2012 at 4:57 AM, Justin Clift jcl...@redhat.com wrote: On 27/08/2012, at 1:00 PM, Daniel Veillard wrote: I tagged the rc2 in the git tree and pushed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ it should include the various fixes that were made on top of rc1 and fix the compilation problem exposed on OS-X, as well as picking libnl3 if available, please give it a try and report, I am still shooting for a final release this Wednesday, Still a no go on OSX. Different error this time: ... libvirtd.c: In function 'main': libvirtd.c:1316: error: 'NETLINK_ROUTE' undeclared (first use in this function) libvirtd.c:1316: error: (Each undeclared identifier is reported only once libvirtd.c:1316: error: for each function it appears in.) libvirtd.c:1322: error: 'NETLINK_KOBJECT_UEVENT' undeclared (first use in this function) make[3]: *** [libvirtd-libvirtd.o] Error 1 make[3]: *** Waiting for unfinished jobs Any ideas? + Justin You can try something like the following to get you a little farther and see if it fails farther on. Just trying to see if we can get Mac OS X built and see what changes need to happen before 0.10.0 goes out final, not necessary proper patches just yet. diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h index 1982dae..c3f3e81 100644 --- a/src/util/virnetlink.h +++ b/src/util/virnetlink.h @@ -34,6 +34,9 @@ struct nl_msg; struct sockaddr_nl; struct nlattr; +#define NETLINK_ROUTE 0 /* Routing/device hook */ +#define NETLINK_KOBJECT_UEVENT 15 /* Kernel messages to userspace */ + # endif /* __linux__ */ int virNetlinkStartup(void); -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2
Doug Goldstein wrote: On Mon, Aug 27, 2012 at 4:57 AM, Justin Clift jcl...@redhat.com wrote: On 27/08/2012, at 1:00 PM, Daniel Veillard wrote: I tagged the rc2 in the git tree and pushed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ it should include the various fixes that were made on top of rc1 and fix the compilation problem exposed on OS-X, as well as picking libnl3 if available, please give it a try and report, I am still shooting for a final release this Wednesday, Still a no go on OSX. Different error this time: ... libvirtd.c: In function 'main': libvirtd.c:1316: error: 'NETLINK_ROUTE' undeclared (first use in this function) libvirtd.c:1316: error: (Each undeclared identifier is reported only once libvirtd.c:1316: error: for each function it appears in.) libvirtd.c:1322: error: 'NETLINK_KOBJECT_UEVENT' undeclared (first use in this function) make[3]: *** [libvirtd-libvirtd.o] Error 1 make[3]: *** Waiting for unfinished jobs I'm seeing the same issue building on an older SLES where HAVE_LIBNL is not defined. Any ideas? + Justin You can try something like the following to get you a little farther and see if it fails farther on. Just trying to see if we can get Mac OS X built and see what changes need to happen before 0.10.0 goes out final, not necessary proper patches just yet. diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h index 1982dae..c3f3e81 100644 --- a/src/util/virnetlink.h +++ b/src/util/virnetlink.h @@ -34,6 +34,9 @@ struct nl_msg; struct sockaddr_nl; struct nlattr; +#define NETLINK_ROUTE 0 /* Routing/device hook */ +#define NETLINK_KOBJECT_UEVENT 15 /* Kernel messages to userspace */ + # endif /* __linux__ */ int virNetlinkStartup(void); This workaround fixed the build. Is this an acceptable fix, or should commits 080bf330 and d5756794 have conditionally called virNetlinkEventServiceStart(...) based on HAVE_LIBNL? Regards, Jim -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2
On Mon, Aug 27, 2012 at 3:39 PM, Jim Fehlig jfeh...@suse.com wrote: Doug Goldstein wrote: On Mon, Aug 27, 2012 at 4:57 AM, Justin Clift jcl...@redhat.com wrote: On 27/08/2012, at 1:00 PM, Daniel Veillard wrote: I tagged the rc2 in the git tree and pushed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ it should include the various fixes that were made on top of rc1 and fix the compilation problem exposed on OS-X, as well as picking libnl3 if available, please give it a try and report, I am still shooting for a final release this Wednesday, Still a no go on OSX. Different error this time: ... libvirtd.c: In function 'main': libvirtd.c:1316: error: 'NETLINK_ROUTE' undeclared (first use in this function) libvirtd.c:1316: error: (Each undeclared identifier is reported only once libvirtd.c:1316: error: for each function it appears in.) libvirtd.c:1322: error: 'NETLINK_KOBJECT_UEVENT' undeclared (first use in this function) make[3]: *** [libvirtd-libvirtd.o] Error 1 make[3]: *** Waiting for unfinished jobs I'm seeing the same issue building on an older SLES where HAVE_LIBNL is not defined. Any ideas? + Justin You can try something like the following to get you a little farther and see if it fails farther on. Just trying to see if we can get Mac OS X built and see what changes need to happen before 0.10.0 goes out final, not necessary proper patches just yet. diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h index 1982dae..c3f3e81 100644 --- a/src/util/virnetlink.h +++ b/src/util/virnetlink.h @@ -34,6 +34,9 @@ struct nl_msg; struct sockaddr_nl; struct nlattr; +#define NETLINK_ROUTE 0 /* Routing/device hook */ +#define NETLINK_KOBJECT_UEVENT 15 /* Kernel messages to userspace */ + # endif /* __linux__ */ int virNetlinkStartup(void); This workaround fixed the build. Is this an acceptable fix, or should commits 080bf330 and d5756794 have conditionally called virNetlinkEventServiceStart(...) based on HAVE_LIBNL? Regards, Jim Yeah that's what I wasn't sure about when I wrote the patch. I can see the argument either way. -- Doug Goldstein -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [Libvirt-announce] Availability of 0.10.0 release candidate 2
On 28/08/2012, at 2:32 AM, Doug Goldstein wrote: snip You can try something like the following to get you a little farther and see if it fails farther on. Just trying to see if we can get Mac OS X built and see what changes need to happen before 0.10.0 goes out final, not necessary proper patches just yet. diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h index 1982dae..c3f3e81 100644 --- a/src/util/virnetlink.h +++ b/src/util/virnetlink.h @@ -34,6 +34,9 @@ struct nl_msg; struct sockaddr_nl; struct nlattr; +#define NETLINK_ROUTE 0 /* Routing/device hook */ +#define NETLINK_KOBJECT_UEVENT 15 /* Kernel messages to userspace */ + # endif /* __linux__ */ int virNetlinkStartup(void); Thanks Dough. This worked, and seems to be the last of the problems. The whole compile worked after this. :) + Justin -- Aeolus Community Manager http://www.aeolusproject.org -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
