Re: [libvirt] [PATCH 1/8] storage: fs: Fix comment for virStorageBackendFileSystemDelete
On 01/09/14 22:06, Eric Blake wrote: On 01/06/2014 09:44 AM, Peter Krempa wrote: The comment was talking about creating the pool while the function is deleting it. Fix the mismatch. --- src/storage/storage_backend_fs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) ACK, safe for 1.2.1 Thanks; Pushed. diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 95783be..6ebdd46 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -962,11 +962,9 @@ virStorageBackendFileSystemStop(virConnectPtr conn ATTRIBUTE_UNUSED, /** * @conn connection to report errors against - * @pool storage pool to build - * - * Build a directory or FS based storage pool. + * @pool storage pool to delete * - * - If it is a FS based pool, mounts the unlying source device on the pool While you're deleting this one, could you fix the other three instances in the file to s/unlying/underlying/? Will do as a follow up. Peter signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/8] storage: fs: Fix comment for virStorageBackendFileSystemDelete
On 01/06/2014 09:44 AM, Peter Krempa wrote: The comment was talking about creating the pool while the function is deleting it. Fix the mismatch. --- src/storage/storage_backend_fs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) ACK, safe for 1.2.1 diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 95783be..6ebdd46 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -962,11 +962,9 @@ virStorageBackendFileSystemStop(virConnectPtr conn ATTRIBUTE_UNUSED, /** * @conn connection to report errors against - * @pool storage pool to build - * - * Build a directory or FS based storage pool. + * @pool storage pool to delete * - * - If it is a FS based pool, mounts the unlying source device on the pool While you're deleting this one, could you fix the other three instances in the file to s/unlying/underlying/? + * Delete a directory based storage pool * * Returns 0 on success, -1 on error */ -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
