Re: [libvirt] [PATCH 2/2] docs: news: Mention changes in memory slot number allocation
On Fri, 2016-11-25 at 13:44 +0100, Peter Krempa wrote: > > You'll also need to close the element properly, or > > building the documentation will fail. > > Right. The format of the file, where we wrap the text back to the column > where the tag starts rather than wrapping it to the column where the > text starts makes it very hard to visually spot this kind of mistake. > > Is there a particular reason to do it in such a weird way? Not really, I mostly went along with the formatting of the existing news.html.in and hacked together a XSLT stylesheet that happened to produce a decent output based on it. Me and Martin have discussed some ways to improve on that, but it'll have to wait for a bit. Please just be patient in the meantime :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] docs: news: Mention changes in memory slot number allocation
On Fri, Nov 25, 2016 at 13:36:01 +0100, Andrea Bolognani wrote: > On Fri, 2016-11-25 at 12:14 +0100, Peter Krempa wrote: > > --- > > docs/news.html.in | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/docs/news.html.in b/docs/news.html.in > > index 0a4b767..2ba25f5 100644 > > --- a/docs/news.html.in > > +++ b/docs/news.html.in > > @@ -34,6 +34,10 @@ > >qemu: Users can now enable debug logging for native gluster > >volumes in qemu using the "gluster_debug_level" option in > >qemu.conf > > > > + memory hotplug: Slot numbers for memory devices are now > > + automatically alocated and thus persistent. In addition slot > > numbers > > s/alocated/allocated/ > > > + can be specified without providing a base address, which > > simplifies > > + user configuration. > > Please drop the period at the end of the sentence. > > You'll also need to close the element properly, or > building the documentation will fail. Right. The format of the file, where we wrap the text back to the column where the tag starts rather than wrapping it to the column where the text starts makes it very hard to visually spot this kind of mistake. Is there a particular reason to do it in such a weird way? Peter signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] docs: news: Mention changes in memory slot number allocation
On Fri, 2016-11-25 at 12:14 +0100, Peter Krempa wrote: > --- > docs/news.html.in | 4 > 1 file changed, 4 insertions(+) > > diff --git a/docs/news.html.in b/docs/news.html.in > index 0a4b767..2ba25f5 100644 > --- a/docs/news.html.in > +++ b/docs/news.html.in > @@ -34,6 +34,10 @@ >qemu: Users can now enable debug logging for native gluster >volumes in qemu using the "gluster_debug_level" option in qemu.conf > > + memory hotplug: Slot numbers for memory devices are now > + automatically alocated and thus persistent. In addition slot > numbers s/alocated/allocated/ > + can be specified without providing a base address, which simplifies > + user configuration. Please drop the period at the end of the sentence. You'll also need to close the element properly, or building the documentation will fail. > > >Improvements ACK with those issues fixed. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
