Re: [libvirt] [PATCH 4/4] Allow choice of shutdown method via virsh

2012-01-19 Thread Eric Blake
On 01/17/2012 04:44 AM, Michal Privoznik wrote:
 Extend the 'shutdown' and 'reboot' methods so that they both
 accept a new argument
 
 --mode acpi|agent
 
 * tools/virsh.c: New args for shutdown/reboot
 * tools/virsh.pod: Document new args
 ---
  tools/virsh.c   |   47 +--
  tools/virsh.pod |   24 
  2 files changed, 61 insertions(+), 10 deletions(-)
 

 @@ -1796,9 +1804,9 @@ Edit the XML configuration file for a storage pool.
  
  This is equivalent to:
  
 - virsh pool-dumpxml pool  pool.xml
 - vi pool.xml (or make changes with your other text editor)
 - virsh pool-define pool.xml
 +virsh pool-dumpxml pool  pool.xml
 +vi pool.xml (or make changes with your other text editor)
 +virsh pool-define pool.xml
  
  except that it does some error checking.
  
 @@ -1853,9 +1861,9 @@ pre-existing volume.
  
  BExample
  
 - virsh vol-dumpxml --pool storagepool1 appvolume1  newvolume.xml
 - vi newvolume.xml (or make changes with your other text editor)
 - virsh vol-create differentstoragepool newvolume.xml
 +virsh vol-dumpxml --pool storagepool1 appvolume1  newvolume.xml
 +vi newvolume.xml (or make changes with your other text editor)
 +virsh vol-create differentstoragepool newvolume.xml

These two whitespace-changing hunks look spurious.  ACK to the rest of
the patch.

-- 
Eric Blake   ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 4/4] Allow choice of shutdown method via virsh

2011-10-05 Thread Eric Blake

On 10/05/2011 11:31 AM, Daniel P. Berrange wrote:

From: Daniel P. Berrangeberra...@redhat.com

Extend the 'shutdown' and 'reboot' methods so that they both
accept a new argument

 --mode acpi|agent

* tools/virsh.c: New args for shutdown/reboot
* tools/virsh.pod: Document new args
---
  tools/virsh.c   |   42 --
  tools/virsh.pod |   12 ++--
  2 files changed, 50 insertions(+), 4 deletions(-)


You remembered the docs.  Thanks :)

ACK.

--
Eric Blake   ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list