Re: [libvirt] [PATCH glib] Disable test suite unless glib = 2.38

2014-02-24 Thread Christophe Fergeau 
On Thu, Feb 20, 2014 at 04:24:52PM +, Daniel P. Berrange wrote:
 diff --git a/tests/Makefile.am b/tests/Makefile.am
 index 56887ce..8cb98e5 100644
 --- a/tests/Makefile.am
 +++ b/tests/Makefile.am
 @@ -1,3 +1,11 @@
 +EXTRA_DIST = \
 + xml/gconfig-domain.xml \
 + xml/gconfig-domain-clock.xml \
 + xml/gconfig-domain-os.xml \
 + $(NULL)
 +
 +if ENABLE_TESTS
 +
  include $(top_srcdir)/build-aux/glib-tap.mk
  
  AM_CFLAGS = \
 @@ -14,7 +22,9 @@ LDADD = \
  
  test_programs = test-gconfig test-events
  
 -dist_test_data = \
 - xml/gconfig-domain.xml \
 - xml/gconfig-domain-clock.xml \
 - xml/gconfig-domain-os.xml
 +else
 +EXTRA_DIST += \
 + test-events.c \
 + test-gconfig.c \
 + $(NULL)
 +endif

This is already committed, and not really important, but the else/endif
block is not needed (on newer automake?) as when deciding which files to
put in the tarball, it ignores the conditionals and picks all files which
would be included for either value of the conditional.

Christophe


pgpAcAJi6zB7g.pgp
Description: PGP signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH glib] Disable test suite unless glib = 2.38

2014-02-21 Thread Pavel Hrdina 

On 20.2.2014 17:24, Daniel P. Berrange wrote:

The TAP harness for glib only works with version 2.38 or later,
so must be disabled for earlier versions

Signed-off-by: Daniel P. Berrange berra...@redhat.com
---


ACK

Pavel

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list